[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] build: shorten macro references
- To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Fri, 5 May 2023 08:07:22 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tyJsGgOmH1j6Xmps5DvUIVknIqyTkutnVPVaG5fiMeI=; b=KNpLwbWStd1hv5xFLDrppYxk89biHjKuq2VfmHpsd+nopjGh/CH96iofcsRo6m+Ep0U/0fECOxUFr19gsNiwwCKF4YpRYF0dvQCyIYbi4mdj2+KwgSpAuxEuJaod4+nUIT9lj9ia+iUylAREXNEqxFVFwjHTKt1+Smt+A322M/5t9WiCooJSqq6ERuta3pKlq65cJBXRQkiIcQ/bhSaKQVBAj+tlDCJX77tGk1GlmaGgJ28YMzlWCJiylBE5rDBItClhC2IlbNzzrlc8g4y6zJfsavpq3XPC93xznRVe//mQeXhqXzKit2VDXYRlQ2Jol3AYyHJOr+uBFc0xj2MEqg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nlZIW4KjZY1+igXQEsb+pJOXns/C4h8Z03/Mdj5349P2YPB7qSZRWqSwW7yFRqpGkZ6uf+qJ9dPSoGuLmdAbC3ZHxc+eoJYFGi1Usw4tOVOXFat3U7G06/5bJ6CAiSc/Usm8PGuZGo8sqN0nCplhdp/097/D4of8asd6JfyQxcy1KJNVkCmdG54saxEdPWQAQrTYpYpnjtt/6zcpSDiNM8f2LEv3EenTJ+E12TxyoZ20c0u2Xo1pLrX1mnZA+xm/bQ+9DCWoCPVBbpoAs+ilVabYGpYsW/Pqjrudcoy2q9J75QtpGdSyNaC5wjtAC5VzrdF+62f0HPammpgGmpm9aw==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Wei Liu <wl@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Volodymyr Babchuk <volodymyr_babchuk@xxxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Bobby Eshleman <bobbyeshleman@xxxxxxxxx>, Alistair Francis <alistair.francis@xxxxxxx>, Connor Davis <connojdavis@xxxxxxxxx>, Anthony Perard <anthony.perard@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Fri, 05 May 2023 06:07:37 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 04.05.2023 19:24, Andrew Cooper wrote:
> On 04/05/2023 5:16 pm, Jan Beulich wrote:
>> Presumably by copy-and-paste we've accumulated a number of instances of
>> $(@D)/$(@F), which really is nothing else than $@. The split form only
>> needs using when we want to e.g. insert a leading . at the beginning of
>> the file name portion of the full name.
>
> From the Kbuild work, we have $(dot-target) now which is marginally more
> legible than $(@D)/.$(@F), and we ought to use it consistently.
Oh, right - let me make yet another patch on top.
>> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
>
> Acked-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, although ...
Thanks.
>> --- a/xen/arch/arm/Makefile
>> +++ b/xen/arch/arm/Makefile
>> @@ -104,9 +104,9 @@ $(TARGET)-syms: $(objtree)/prelink.o $(o
>> $(MAKE) $(build)=$(@D) $(@D)/.$(@F).1.o
>> $(LD) $(XEN_LDFLAGS) -T $(obj)/xen.lds -N $< $(build_id_linker) \
>> $(@D)/.$(@F).1.o -o $@
>> - $(NM) -pa --format=sysv $(@D)/$(@F) \
>> + $(NM) -pa --format=sysv $@ \
>> | $(objtree)/tools/symbols --all-symbols --xensyms --sysv
>> --sort \
>> - >$(@D)/$(@F).map
>> + >$@.map
>
> ... any chance we can get a space between > and $ like we do almost
> everywhere else?
Since "almost everywhere else" wasn't quite right for xen/arch/*/Makefile
I was first inclined to say no, but I can easily insert blanks when doing
the $(dot-target) conversion as well, and then it looks like it'll end
up fully consistent (in this one regard).
Jan
|
