[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 1/2] restrict concept of pIRQ to x86
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Date: Thu, 4 May 2023 09:44:11 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LTFv2L769fnTJo8Ke6VVXviRQQALqA65dGzZvVdiga8=; b=JwVWUjXfUX5TZ6bZwbKLIZLyN9UEh2hAozXChpszJFkVGBXDp0qazv+o4QAY+SpB+e9DjZenoWLVNx9yxYhyG4CRh65O74X1ceXE+y+/SKb795+2ZWmdsAKvIDTDx9PI44lsrRYjaqtTQ5fRJ+N0jPoqSiAsf+wAj1YFHJyYM7PWRZBwq2RWM5fqbHwTtSRo238nWoaphKRYmamWQV3Sk7ViHzSucqkj2GczPOFjBfwUAT6wsXb7f02vsc2pfSP4M7vx+NoVRt8477qu1kJqhIQhk7LqMG9IAP6D1zO2KJgUjfMQf9syOMU2livccuZUOzcSoFHwrcZPxtl7FzcZRA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dPPOv+E/oG41XGUAawPerIwgks5lQUiVoVJjupgDW4R4nGlEVv7Hb1QCut/Ab4zSquRMnS5VgamV6e0aBr/Ku9Ywq4KZeR3rsCMpT3ek/lkaeCh4BzphM1ULrHPpGpx3FTEv63GQi6m8IlAUa9zxDODnrLqsk5zFnQFs35j0Wo/FsvpMKB4iYe+rv3z0fmsYs7HvnmVBMzm4eMI+GFwC2ItuUyPcybOpmAhQem5VidnqzaAGZvO5O3ikQxBnMTVQStYYRTU0YslNtWUjRFGe4VYo4TByVpuB53v6eQ+2I3dUE0s69FcjwQ/J+3MX5wZOKAKbFd+Lgqn6+oK0Plv+nA==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Volodymyr Babchuk <volodymyr_babchuk@xxxxxxxx>
- Delivery-date: Thu, 04 May 2023 07:44:37 +0000
- Ironport-data: A9a23:PLdoCqKsjLrZUAwhFE+RVZQlxSXFcZb7ZxGr2PjKsXjdYENS0jAOn zAeUDuEbKnZMWakco8kPoXjp08O6JCBztQ2T1RlqX01Q3x08seUXt7xwmUcnc+xBpaaEB84t ZV2hv3odp1coqr0/0/1WlTZhSAgk/rOHvykU7Ss1hlZHWdMUD0mhQ9oh9k3i4tphcnRKw6Ws Jb5rta31GWNglaYCUpJrfPSwP9TlK6q4mhA4wRiPakjUGL2zBH5MrpOfcldEFOgKmVkNrbSb /rOyri/4lTY838FYj9yuu+mGqGiaue60Tmm0hK6aYD76vRxjnVaPpIAHOgdcS9qZwChxLid/ jnvWauYEm/FNoWU8AgUvoIx/ytWZcWq85efSZSzXFD6I+QrvBIAzt03ZHzaM7H09c5bCEBUy eNfIQtQSRuvru2T4Y+CEs1F05FLwMnDZOvzu1lG5BSAVLMMZ8CGRK/Ho9hFwD03m8ZCW+7EY NYUYiZuaxKGZABTPlAQC9Q1m+LAanvXKmUE7g7K4/dnpTGNnWSd05C0WDbRUsaNSshP2F6Ru 0rN/njjAwFcP9uaodaA2iv01rWVw3ikBOr+EpWAqMdskgK0x1c4BR8dS3++rtu8mFWhDoc3x 0s8v3BGQbIJ3E6hQ8T5Xha4iGWZpRNaUN1Ve8Uq5QfIxqfK7gKxAmkfUiUHeNEgrNUxRzEhy hmOhdyBLT5ytLyYT1qN+7HSqim9UQAONnMLbyIASQoD4vHgrZs1gxaJScxseIaqivXlFDe2x CqFxAA0iq8Pl8cN2+O+9ErenjO3jpHTS0g+4QC/dnyi6gR1dYu0fbui4FLQ7etDBIuBR1zHt 38B8/Vy98gLBJCJ0SaLEOMEGejw4+7faWONx1lyA5Mm6jKhvWa5epxd6y1/I0EvNdsYfTjuY wnYvgY5CIJvAUZGpJRfO+qZY/nGB4C7fTg5fpg4tuZzX6U=
- Ironport-hdrordr: A9a23:rYIDbaABe6xfAGPlHelo55DYdb4zR+YMi2TDt3oddfU1SL38qy nKpp4mPHDP5wr5NEtPpTniAtjjfZq/z/5ICOAqVN/PYOCPggCVxepZnOjfKlPbehEX9oRmpN 1dm6oVMqyMMbCt5/yKnDVRELwbsaa6GLjDv5a785/0JzsaE52J6W1Ce2GmO3wzfiZqL7wjGq GR48JWzgDQAkj+PqyAdx84t/GonayzqK7b
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Wed, May 03, 2023 at 05:33:05PM +0200, Jan Beulich wrote:
> --- a/xen/include/xen/sched.h
> +++ b/xen/include/xen/sched.h
> @@ -438,12 +438,14 @@ struct domain
>
> struct grant_table *grant_table;
>
> +#ifdef CONFIG_HAS_PIRQ
> /*
> * Interrupt to event-channel mappings and other per-guest-pirq data.
> * Protected by the domain's event-channel spinlock.
> */
> struct radix_tree_root pirq_tree;
> unsigned int nr_pirqs;
> +#endif
Won't it be cleaner to just move this into arch_domain and avoid a
bunch of the ifdefary? As the initialization of the fields would be
moved to arch_domain_create() also.
Maybe we would want to introduce some kind of arch-specific event
channel handler so that the bind PIRQ hypercall could be handled
there?
Thanks, Roger.
|