Re: [PATCH v2 01/13] tools/xenstore: verify command line parameters better

[Julien Grall <julien@xxxxxxx>]

Hi Juergen,

On 30/03/2023 09:49, Juergen Gross wrote:
> Add some more verification of command line parameters.
>
> Signed-off-by: Juergen Gross <jgross@xxxxxxxx>
> ---
>   tools/xenstore/xenstored_core.c | 19 +++++++++----------
>   1 file changed, 9 insertions(+), 10 deletions(-)
>
> diff --git a/tools/xenstore/xenstored_core.c b/tools/xenstore/xenstored_core.c
> index 6e2fc06840..7214b3df03 100644
> --- a/tools/xenstore/xenstored_core.c
> +++ b/tools/xenstore/xenstored_core.c
> @@ -2809,7 +2809,7 @@ int main(int argc, char *argv[])
>                         no_domain_init = true;
>                         break;
>                 case 'E':
> -                       hard_quotas[ACC_NODES].val = strtoul(optarg, NULL, 10);
> +                       hard_quotas[ACC_NODES].val = get_optval_int(optarg);
Ah, so that exactly what I was exactly on the other series.

I would be OK if this is kept separate:

Acked-by: Julien Grall <jgrall@xxxxxxxxxx>

Cheers,

--
Julien Grall