[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] cmdline: document and enforce "extra_guest_irqs" upper bounds
- To: Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Wed, 3 May 2023 12:43:23 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tw0s9+B+lOUlPzGuqqHZc+BliG9zWYxRoLru8awX5BU=; b=dEYtG6yHF8kJH14ULqSWjrr99kgp27zP+hYWqB8vwUCWVq6IJv6kM3BT9Lv9GQmXzZGBmD5Kuz+giezgclhLfErhlvcxV/LtaYC09GqzcvQ2B2kWlEy6YWPaWF+ZV3Z4avdB/oiFnn5FZK+wSlCoiF1DWxd6TW+0CIk0T7fYTqBt3nDGJw3Zb7tTzKaC5xKCK8x89GoIxo6WpHv6JbTjMgSAtX3G9id15lNJDsEaIhwfnh4FXNX4qX87leIoXnPXorIXO3oy9sGROFCfOWd2W5+oYz9jysrsfEB7PqGCPAcjGpJf6+sOd6RCC4MaKvkMHzGocl3anR/ji9hmTXJchA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=btIpTBakCJSSCiuxUHE3FTP+qS5cGuyPWFYaoqDxenWoWTA60zqkJcy8u7OeWu0AIiLfos9TGcMlp40IwsXHaRntt6s4BsnjrZRA3tnfV9IYX4iivVnd/AhaIGbf7/xnPT4djGrA+pxMAmau2eHND0hG10chn/bojj4Zzr9V1QyPe27hyG84GcZSEeIwg1hQeNEVi+2B+yPoytYDIr558910D2sRYgyBPPfPzwItwbdAbhMzKw1Vwg7nMkT+wV5g9pn7tn8SeF5ZVN19iKgEYo28MKQ7BlTQgTV29SugVLsxU4NWDFCKo6/6e8RsYiIZMnl72JJQQgbR3G1axyR1iw==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: George Dunlap <george.dunlap@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Volodymyr Babchuk <volodymyr_babchuk@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Delivery-date: Wed, 03 May 2023 10:43:41 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 04.04.2023 12:40, Jan Beulich wrote:
> On 04.04.2023 12:34, Andrew Cooper wrote:
>> On 04/04/2023 10:20 am, Jan Beulich wrote:
>>> --- a/xen/arch/arm/include/asm/irq.h
>>> +++ b/xen/arch/arm/include/asm/irq.h
>>> @@ -52,7 +52,7 @@ struct arch_irq_desc {
>>>
>>> extern const unsigned int nr_irqs;
>>> #define nr_static_irqs NR_IRQS
>>> -#define arch_hwdom_irqs(domid) NR_IRQS
>>> +#define arch_hwdom_irqs(d) NR_IRQS
>>
>> I know it's not your bug, but this ought to be (d, NR_IRQS) as you're
>> changing it.
>
> I can add this (with a cast to void), but I'll leave the final say to
> Arm maintainers.
Arm maintainers,
may I ask for some kind of statement here? I'd be happy to follow
Andrew's request, but I don't want to then end up with an "unrelated
change" objection.
Thanks, Jan
|
