Re: [PATCH v4 07/13] tools/xenstore: use accounting data array for per-domain values

[Juergen Gross <jgross@xxxxxxxx>]

On 02.05.23 21:09, Julien Grall wrote:
> Hi Juergen,
>
> On 05/04/2023 08:03, Juergen Gross wrote:
> > diff --git a/tools/xenstore/xenstored_domain.h 
> > b/tools/xenstore/xenstored_domain.h
> > index 5cfd730cf6..0d61bf4344 100644
> > --- a/tools/xenstore/xenstored_domain.h
> > +++ b/tools/xenstore/xenstored_domain.h
> > @@ -28,7 +28,10 @@ enum accitem {
> >       ACC_NODES,
> >       ACC_REQ_N,        /* Number of elements per request. */
> >       ACC_TR_N = ACC_REQ_N,    /* Number of elements per transaction. */
> > -    ACC_N = ACC_TR_N,    /* Number of elements per domain. */
> > +    ACC_WATCH = ACC_TR_N,
> > +    ACC_OUTST,
> > +    ACC_MEM,
> > +    ACC_N,            /* Number of elements per domain. */
> >   };
> >   void handle_event(void);
> > @@ -107,9 +110,8 @@ static inline void domain_memory_add_nochk(struct 
> > connection *conn,
> >   void domain_watch_inc(struct connection *conn);
> >   void domain_watch_dec(struct connection *conn);
> >   int domain_watch(struct connection *conn);
> > -void domain_outstanding_inc(struct connection *conn);
> > -void domain_outstanding_dec(struct connection *conn);
> > -void domain_outstanding_domid_dec(unsigned int domid);
> > +void domain_outstanding_inc(struct connection *conn, unsigned int domid);
> AFAICT, all the caller of domain_outstanding_inc() will pass 'conn->id'. So it 
> is not entirely clear what's the benefits to add the extra parameter.
domain_acc_add() will need conn. I agree that I should drop the domid
parameter.


Juergen

Attachment: OpenPGP_0xB0DE9DD628BF132F.asc
Description: OpenPGP public key

Attachment: OpenPGP_signature
Description: OpenPGP digital signature