[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] automation: optimize build jobs order


  • To: Marek Marczykowski-Górecki <marmarek@xxxxxxxxxxxxxxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
  • From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
  • Date: Sat, 29 Apr 2023 21:00:53 +0100
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=z0477FqDiZXn9zUb4PFl911Gg9UxC9omPfnirEG+BOo=; b=kiI5l2YVkAXjMVF9gGtm1N9CRFHlOJzExeag72hhxG9ZqCkJvlIusy1sTvPHFzMv/UesHIFFfPOnnR5tMaolSb4arMuqfzD0NgTv1ztl+MaOkj7RGAKroLKw5K5F1qmsZROThXgUM0aon8pnMs+HM4eLVjPla+/lSkYqZXvw6ZbKQnUXe8Z6UOI9ImfOEOwxfnZ4oK0kD6w+lLpn9JU0XeRRPlshuu1NYHm+GxsObBOT1HOxiXk8zqxUN7p9MSutrb2maQj3NpcG2FSBGv2X9OPgnzpCx8n5XOLG3zIiwl0J59Np1ezzevu2wJWmZgObEiuKyJZNeVPdmpfE6cTvig==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GF1SccVHTZjv/P9YHzzvEh89TPiIDZ2DkGcrNaUybeDnK6ZcpC6YbLqsWNMv+1Feli/uZasTsN9WFTGl3NXmObsjXDD5OVaNpF2sEBcQmVp6w1mhoHecMRCPYo40afuBhSJie89OL5g8FZCFoiPyux/3yH3aEIdET8JC09Ga0aNfmDtLxTEVipzVZPUoo4zD/CQrEip8MMuCSBsI4+f5Ivd/6uDJ2GIAg9IZPlWHobvhi6Al0HX8bk4vGR0XdTVhGbguLSrLoMzkBh2qaSa4FsUKkil3k6epxhwtpU3znQ1xDxTGZc7EBRAWI4h1YjAKt01pxBKFvslb9aGPRfci9A==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
  • Cc: Doug Goldstein <cardoe@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>
  • Delivery-date: Sat, 29 Apr 2023 20:01:20 +0000
  • Ironport-data: A9a23:MjyAN6AhVXm9ThVW//jiw5YqxClBgxIJ4kV8jS/XYbTApDInhDdRz WZLWG+OOa6DYGPxfNBzaoyyp00PuJaEz9JjQQY4rX1jcSlH+JHPbTi7wuUcHAvJd5GeExg3h yk6QoOdRCzhZiaE/n9BCpC48T8nk/nOHuGmYAL9EngZbRd+Tys8gg5Ulec8g4p56fC0GArIs t7pyyHlEAbNNwVcbyRFuspvlDs15K6p4G9C7wRkDRx2lAS2e0c9Xcp3yZ6ZdxMUcqEMdsamS uDKyq2O/2+x13/B3fv8z94X2mVTKlLjFVDmZkh+AsBOsTAbzsAG6Y4pNeJ0VKtio27hc+ada jl6ncfYpQ8BZsUgkQmGOvVSO3kW0aZuoNcrLZUj2CA6IoKvn3bEmp1T4E8K0YIw3M1LAV4N0 uEkJDEnQBalgMyZ27+/Y7w57igjBJGD0II3nFhFlW2cIdN4BJfJTuPN+MNS2yo2ioZWB/HCa sEFaD1pKhPdfxlIPVRRA5U79AuqriCnL3sE9xTK/uxrvQA/zyQouFTpGPPTdsaHWoN+mUGAq 3id12/4HgsbJJqUzj/tHneE37eRw32mA9hIfFG+3qB60E2Y6TBIMwdIThijgaGYiA2iYN0Kf iT4/QJr98De7neDS9DnWhSirX2svxgCWsFRGek39AGMzKXP5w+TQGMDS1ZpeNEg8cM7WzEu/ luIhM/yQyxitqWPTnCQ/avSqim9UQAeJHUOYiIsRgIf797u5oo0i3rnVc1/GaS4itn0HzDYw D2QqiU6wbIJgqY2O76T+FnGh3ego8bPRwttugHPBDr5sEV+eZKvYJGu5R7D9/FcIY2FT16H+ n8Zh8yZ6+NIBpaI/MCQfNgw8HiSz67tGFXhbZRHRfHNKxzFF6afQL1t
  • Ironport-hdrordr: A9a23:E5tkOaFb/woCy8BtpLqE0seALOsnbusQ8zAXPiFKJSC9F/byqy nAppsmPHPP5gr5IUtQ/+xoWpPhfZqsz/9ICOAqVN/JMTUO01HYT72Kg7GSpwHIKmnT8fNcyL clU4UWMqyWMbGit7eZ3OBvKadE/OW6
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 29/04/2023 3:27 pm, Marek Marczykowski-Górecki wrote:
> Put jobs that are needed for (any) test earlier, so the tests can start
> running in parallel to builds.
> This commits splits only x86 build jobs into two sections (one on top
> and one on bottom), but keep ARM build jobs in one section, as most of
> them have some test connected and the few that do not are not worth
> reducing readability of the file.
>
> And also, put artifacts jobs at the very beginning, not the very end.
>
> Signed-off-by: Marek Marczykowski-Górecki <marmarek@xxxxxxxxxxxxxxxxxxxxxx>
> ---
> This made the pipeline to complete within 45 minutes. This isn't big
> improvement on its own, but should make adding more runners more
> beneficial. While looking at it in real time, most jobs were really
> waiting for available runners and not stuck on dependencies anymore.

That's still 1/4 better than before.  I'd say that's a good improvement
all on its own.

As for the patch, Its not the easiest to review.

The test artefacts section is new, and is just moving various jobs
forwards in the file.

I suspect that if you split the patch into two, first forming the test
artefacts section, and second rearranging the existing x86 tests, the
result might be readable (or at least, more readable).

The key (I think) will be to keep the # Jobs below this line, and
following archlinux tests unmodified in patch 1, at which point the diff
ought to render as one block insertion, then scattered deletions.

I suspect the second patch is going to be a mess however you try to
rearrange it, so I wouldn't worry too much if this approach doesn't work.

~Andrew



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.