[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: xen | Failed pipeline for staging | 6a47ba2f
- To: Stefano Stabellini <sstabellini@xxxxxxxxxx>, alejandro.vallejo@xxxxxxxxx
- From: andrew.cooper3@xxxxxxxxxx
- Date: Sat, 29 Apr 2023 12:41:26 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gdywTMgkRK0eSOU+VAX0t/M8x8K1iVjOblidHhBmENU=; b=S7+CDJUtL4z4FHcoYhcOqqsBjZU8QJWWV0xIVglv9LH1NpbDR0Ma3JsV6O+zOAOZGRa/vpEzxQbOEmcCvNklo9oHkwjIMQCgmj+OT4jo3WEmGLTBHkeHQtFwu0SoAxyXOpQa4XySq3W7PcRQRYBM4wQMYfpC83jtGNeLRxhUxM5lkG7fCbc3VlzkdKRG3rwwN/XBpacu+QfF02aSGMpSHCtI+qN0GyNpAYOLrNfb+DLlyRB+oDCZLGoXt9OeGHSs4Bx5llN5hKvpW1mojj1MHqiuP4EbFjX0t5FXlB1MP/TSjV8HZrGOXYZlyjbcUMxVGO+z3G8EACcyBcd4jxVhQg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fmsfvUHIzRyf+1rX+0xJWaB8LhkCfCFtInUQa3CsuN7vvMdiCBrXHEUYIJMODRS7drezrr4DZNeb9ILwywCIxCRMDTlWNJhPMZ6x1t07e2vjyvjPhmeZYwGHtSi445mcg9COElcrNSbiMt9kTA8lPVuurZdFDO/gbJKZrzCNiXTJh82b2213stNiLDbeAuOzA6/1AuR4ZgbFIFXM1K7sLjn2joJg+pppJWK3SHp2IZjoiYm0oI4FnTGI2zObmtQftSUlHqKCIWyZdf0t0ET0NCqdRV4hgllatph+oTA58X+va6UakJME0xledt0typZId+IxZvMijkAN5wnUSeL/iw==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: committers@xxxxxxxxxxxxxx, michal.orzel@xxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Sat, 29 Apr 2023 11:42:03 +0000
- Ironport-data: A9a23:tC+ed6tfZMhKGPfsamG9DCeSWOfnVLxfMUV32f8akzHdYApBsoF/q tZmKWCBafiOY2OjLdAnPY60901S75GDzdJrHldo+CtkFnhE+JbJXdiXEBz9bniYRiHhoOCLz O1FM4Wdc5pkJpP4jk3wWlQ0hSAkjclkfpKlVKiffHg3HVQ+IMsYoUoLs/YjhYJ1isSODQqIu Nfjy+XSI1bg0DNvWo4uw/vrRChH4bKj6Vv0gnRkPaoQ5AOExiFPZH4iDfrZw0XQE9E88tGSH 44v/JnhlkvF8hEkDM+Sk7qTWiXmlZaLYGBiIlIPM0STqkAqSh4ai87XB9JFAatjsB2bnsgZ9 Tl4ncfYpTHFnEH7sL91vxFwS0mSNEDdkVPNCSDXXce7lyUqf5ZwqhnH4Y5f0YAwo45K7W9yG fMwaz8mcj7ZoNyK46viTfRGlPomLPa6M9ZK0p1g5Wmx4fcOZ7nmGv2Pz/kHmTA6i4ZJAOrUY NcfZXx3dhPcbhZTO1ARTpUjgOOvgXq5eDpdwL6XjfNvvy6Pk0ouiP60aIK9lt+iHK25mm6xo G7c8nu/KRYdLNGFkhKO8262h/+JliT+MG4XPOTgqaEz3wTCnQT/DjUHaWr8j9yDtHeSQupFc VQqwXMDp4sLoRnDot7VGkfQTGS/lgUHR9NaHuk+6QeM4qnZ+QCUAi4DVDEpQNUiuc0/QzAw0 RmXltftCD5omLaRTm+RsLyTqFuaMi8QKG4eeSIeViMV7t/7uoYxgxnTCNF5H8adi9z+GTj0h TeQviU6r7wWgYgA0KDT1UDKhXegq4bESiYx5x7LRSS14wVhfomnaoe0r1/B4p59wJ2xS1CAu D0OnZeY5eVXVZWVznXVGKMKAa2j4OuDPHvEm1lzEpI99jOrvXm+YYRX5zI4L0BsWioZRQLUj IbokVs5zPdu0LGCNMebv6rZ5xwW8JXd
- Ironport-hdrordr: A9a23:iLkkfaDqMZUvJKrlHemW55DYdb4zR+YMi2TDtnocdfUxSKelfq +V88jzuSWbtN9pYgBHpTnjAsm9qALnlKKdiLN5Vd3OYOCMghrKEGgN1/qH/xTQXwH46+5Bxe NBXsFFebrN5IFB/KTHCd+DYrMd/OU=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 29/04/2023 4:05 am, Stefano Stabellini wrote:
> On Fri, 28 Apr 2023, GitLab wrote:
>> Pipeline #852233694 triggered by
>> [568538936b4ac45a343cb3a4ab0c6cda?s=48&d=identicon]
>> Ganis
>> had 3 failed jobs
>> Failed jobs
>> ✖
>> test
>> qemu-smoke-dom0less-arm64-gcc
> This is a real failure on staging. Unfortunately it is intermittent. It
> usually happens once every 3-8 tests for me.
>
> The test script is:
> automation/scripts/qemu-smoke-dom0less-arm64.sh
>
> and for this test it is invoked without arguments. It is starting 2
> dom0less VMs in parallel, then dom0 does a xl network-attach and the
> domU is supposed to setup eth0 and ping.
>
> The failure is that nothing happens after "xl network-attach". The domU
> never hotplugs any interfaces. I have logs that show that eth0 never
> shows up and the only interface is lo no matter how long we wait.
>
>
> On a hunch, I removed Alejandro patches. Without them, I ran 20 tests
> without any failures. I have not investigated further but it looks like
> one of these 4 commits is the problem:
>
> 2023-04-28 11:41 Alejandro Vallejo tools: Make init-xenstore-domain use
> xc_domain_getinfolist()
> 2023-04-28 11:41 Alejandro Vallejo tools: Refactor console/io.c to avoid
> using xc_domain_getinfo()
> 2023-04-28 11:41 Alejandro Vallejo tools: Create xc_domain_getinfo_single()
> 2023-04-28 11:41 Alejandro Vallejo tools: Make some callers of
> xc_domain_getinfo() use xc_domain_getinfol
In commit order (reverse of above), these patches are:
1) Modify the python bindings and xenbaked
2) Introduce a new library function with a better API/ABI
3) Modify xenconsoled
4) Modify init-xenstore-domain
The test isn't using anything from 4 or 1, and 2 definitely isn't
breaking anything on its own.
That just leaves 3. This test does turn activate xenconsoled by virtue
of invoking xencommons, but that doesn't help explain why a change in
xenconsoled interferes (and only intermittently on this one single test)
with `xl network-attach`.
The xenconsoled change does have correctness fix in it, requiring
xenconsoled to ask for all domains info in one go. This does mean it's
hypercall-buffering (i.e. bouncing) a 4M array now where previously it
was racy figuring out which VMs had come and gone.
~Andrew
|
