[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 1/7] tools: Make some callers of xc_domain_getinfo use xc_domain_getinfolist



Answers inlined

On Thu, Apr 27, 2023 at 10:51:03AM +0100, Andrew Cooper wrote:
> Just as a note for the subject, we more commonly write function names
> with ()'s.

No harm in abiding by that. Done on v2.

> > +            "crashed",         (info[i].flags & XEN_DOMINF_shutdown) &&
> > +                                 (dominfo_shutdown_reason(&info[i]) == 
> > SHUTDOWN_crash),
> 
> Isn't this your dominfo_shutdown_with() from patch 6 ?
> 
> I'd pull that forward to this patch too, and use it here.

It is indeed. Done locally on v2.

Cheers,
Alejandro



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.