[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 4/4] x86/msi: clear initial MSI-X state on boot
- To: Jason Andryuk <jandryuk@xxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Mon, 24 Apr 2023 17:30:03 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wDeIOqfcbR2UUhbgoEWDvtWfNlE2iU/FWi3AzS6QAiA=; b=CIvbBDN3OHMJiaGbQ3dwDOjywJFCRdPbH9P8mXrdPc7dWQc/rgMMGAaZC+ml0x67fyP4QH/kCkgWXDBMM40H8LlNbgyW6+EMbtEz2jSvdiwQi1kc4k8KgucL+knTp7k9dJGjVSj78CcdjZTQ0VVddNHtyBXRR66BU5KDiHVB1DmAJpZXiaMjwA6bzFCB9Vr03KOhZcl3zcn0JLfc+e/P8yFIKt0hPlHfR9btYGlmQEVeoDXUshpKpzLds/6sjxv1HKLX+oJPoheUEPo+HPsSr1Eod7yf8U3vO0HVJdKhuhbn/as2lDVzW8je78NnMhlPquzQLc1eZqkEmJgZjaut0w==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XUJB5Fiu/zXMXo5b2KK0IOUNYr9dpyniYy/necX4UdQjJLTT8OAwdAB9G9pxxUv3I9YgJXE2ytLtRuSv5wQg7ELUN8yNzq+J4ZOHAbqINI3VmpGPv35jSxBb+NBQmoAAv1Gk1q3TC3l6T5fukFggQ5NDSKbu+vF5TP6S5s2tc97N6xUm5vRvnEejyCe6EHJwWumkmaWBQmqpQ6pHr/XZSVrsqvo8DXsAPN4ncpqDazvt8DHsVg2Hjg1LktYizzeMizire2fiZFRQADmTz4iOWtkRtLVqiFv/aVhtg+N65dZh4hdK9GMCpuDP4jFDKZzzdpZnpDR2fKsrmmrWVmyC2Q==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Marek Marczykowski-Górecki <marmarek@xxxxxxxxxxxxxxxxxxxxxx>, Paul Durrant <paul@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Mon, 24 Apr 2023 15:30:46 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 24.04.2023 17:25, Jason Andryuk wrote:
> On Mon, Apr 24, 2023 at 10:19 AM Jan Beulich <jbeulich@xxxxxxxx> wrote:
>> Jason - any chance of getting a Tested-by: from you?
>
> I'm building v3 now. v2 worked for clearing MASKALL on initial boot.
>
> I posted in these two messages - a summary is below.
> https://lore.kernel.org/xen-devel/CAKf6xpto87QRSKT2qc1yApNfaw2SrLLxPoytYJv_jEbYTAbjCg@xxxxxxxxxxxxxx/
> https://lore.kernel.org/xen-devel/CAKf6xptHALLR-Qjf=p5y0o9Ud2V7eFMJuB8Ap-PLjv-N7PAJVQ@xxxxxxxxxxxxxx/
>
> OpenXT has a patch that performs an extra reset after domain shutdown,
> and that causes Xen to set MASKALL. I confirmed by removing it. So
> this patch helps with clearing MASKALL on host boot, but with the
> OpenXT patch, rebooting a domain fails. MASKALL gets set on VM
> shutdown and then the subsequent boot can't assign the device.
>
> So this patch is helpful in some scenarios, but it was also an issue
> caused by the OpenXT patch. Does that make it unsuitable for
> inclusion?
What is "it" here? If I get your reply right, there is a similar issue
left unaddressed by this version of the change (and as was said before,
a device reset changing state that Xen tracks or otherwise cares about
needs to be reported to Xen). Yet that doesn't really fit with the
question, at least the way I read it ...
Jan
> I assume the OpenXT patch wasn't an issue previously since
> MSI-X was never enabled.
>
> Regards,
> Jason
|
