[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 0/3] hvm: add hvm_funcs hooks for msr intercept handling


  • To: Xenia Ragiadakou <xenia.ragiadakou@xxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Mon, 24 Apr 2023 17:11:44 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7D4CWq3/ocWJ3zYqlZtaj3TsyERB+doYS6MmyRBvfdE=; b=LGWzAtTm268f4GMLJUCpQuajYz0lYggmOrur+xdkKc0izBig+c6cQlFz6WEiCc0wgdVLSQ/tcYtb+Vn9j7Db1ljIyI9bBhL2N2BfZb5pn1sGbEAhhaCh+D9QHY1Kh0HD2RJjWiIFJvlOY1gyMtTmPa2WHXFmlCr5uv1YRMAtnxBFuJkM7T3NQxrc/dkLnXFq+SytD447UxXrMNm7VmmwPlvUNdauk1+f5+mpmo+knspbdvhJssvscXbQOMnG1PoMDRPPjsSsFNJYs2WtuToevsNzH/KKb133uJIhFvqXf7CDpu47oiVke/kZO88q+4ISvRG36pnrzNyR870AIo2yYQ==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FYyJ1MTGJhGgCpmEYKhIJKjEi7BQ8+BKcMqYWocszGQRbDFH6IxN4UTVqqakrwhHzw5eSdp79o4gW40PoM0JWI4C+XAHB7tOSHZNNVPqpeZnQtNJQy+HmxuL7MszNiwTvBXgl0F/FVJ+7N36/2CD7GMhM/KBtsQQnhaIth2RIXSpMtsoAT40DBNVQGu52/Wq/Muh0Skht4n6432Ww17UCwbfaj3Rw9cQJ7MlObazmFfahNztyQ15PzsiQenIHlYJoF6Br6oCsP0Avbw+fvqJTV8C/3ZzNkvMWIQwbmYr/4uoHFO8HFoJW0MEaOHuQFyV1Oq8F2J42Pj7D4af/zslYg==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
  • Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Jun Nakajima <jun.nakajima@xxxxxxxxx>, Kevin Tian <kevin.tian@xxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
  • Delivery-date: Mon, 24 Apr 2023 15:12:01 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 24.04.2023 10:20, Xenia Ragiadakou wrote:
> This patch series aims to make the msr intercept handling, performed in
> vpmu code, virtualization technology agnostic.
> It creates a common interface for setting/clearing the msr intercepts and
> then add hooks to the corresponding hvm_funcs table to be able to call the
> svm/vmx specific handlers through a generic hvm wrapper function.
> 
> Version 2 addresses the comments made on version 1 to ease further review.
> 
> Still there is a pending question made by Jan, whether there could be other,
> than the vpmu one, use cases that would require msr intercept handling to be
> performed outside of virtualization techonology-specific code, and whether
> this abstraction is actually usefull to have.

Just for reference: The code changes look okay to me now. They could get my
ack, provided we really want to go this route (which I continue to be
unconvinced of).

Jan




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.