[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2] xen: add support for crash dump analysis with xen.efi
- To: Juergen Gross <jgross@xxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Mon, 24 Apr 2023 16:50:57 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2MzG3FcdovRv+RtWxcUhj/7yaDzpfcXx54EusU2lqs4=; b=IS0fqKmLcxRVKfQ+LXyEtbVwYtV/cRF0/dXXv3aoF2Et2099/9r+a30tWAO0Ok1TRwkm4riF7lJ4a7jMTR+4/YiUnaxXtRcx60nSVcGZ7OUSoyzGA8IODDl2S0Ft+elHeUCINV/46AidF9fdio4x+JfUnM5NWtTt0EA22LUZIVpeVMQ37L+W3XNiXlvrrmn4+ckvRDt1mpba68DrPov1FW9bqwfTONvpJk9BvW7xCDTHpBRjsr7Fqf7opkoGB7c2K56p6+ZiY/M84jW2E/u26R7zBbGHBhFL2j3TjLSVEZ3OLScKiNRUTjzrtS24iHqS+uKrsA51IfPqWurlZSOtfA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jwskvd46SqlTRso5VWtWBCGnVBRuI7PGlJ0n5SgW+IW3scqgDPh3fZadNgA8fAM/Cp2UsRogOrT6yH327Dlldg15lVCrcR0yCSiIc4w814oYUHJ900qCvz0I+k710vUa8CbaH7kX7Ut/xLrk9sUSeci7z4Gv0KA9Mb1Jr9RCTHq1CQOE0e0VWqoqfJJNk/SCiXVkiZiSTLLvU1AsBr4tgw07Z4uwl13k2b3yWjeAwKATUJCV9rNgazncGF0PkvZKRr7lwzJhhbclOPXh6czg6mDI5ZDbONRTFpgw+c0GyMjwBabnzbQmxvFSjx3oZPOMdF07KFJB8t7+emqKlYFXsA==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Mon, 24 Apr 2023 14:51:28 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 24.04.2023 16:30, Juergen Gross wrote:
> --- a/xen/arch/x86/Makefile
> +++ b/xen/arch/x86/Makefile
> @@ -226,6 +226,9 @@ endif
> $(@D)/.$(@F).1r.o $(@D)/.$(@F).1s.o $(orphan-handling-y)
> $(note_file_option) -o $@
> $(NM) -pa --format=sysv $(@D)/$(@F) \
> | $(objtree)/tools/symbols --all-symbols --xensyms --sysv
> --sort >$(@D)/$(@F).map
> +ifeq ($(CONFIG_DEBUG_INFO),y)
> + $(if $(filter --strip-debug,$(EFI_LDFLAGS)),:,$(OBJCOPY) -O
> elf64-x86-64 $@ $@.elf)
This only addresses one of the two earlier raised aspects, as you didn't
use what I proposed:
$(if $(filter --strip-debug,$(EFI_LDFLAGS)),:)$(OBJCOPY) -O
elf64-x86-64 $@ $@.elf
Quite possibly because there was a blank missing in there, to separate
the colon from $(OBJCOPY). Preferably with the adjustment (which I'd
be fine doing while committing, as long as you're okay)
Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
To also mention what we have just discussed: Since we're talking about
duplicating over 30Mb of data (at least according to my build), an
option is going to be to then strip debug info off of xen.efi itself,
getting its size into reasonable range again.
Jan
|
