[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH v3 02/17] xen/arm: implement helpers to get and update NUMA status
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Henry Wang <Henry.Wang@xxxxxxx>
- Date: Thu, 20 Apr 2023 12:48:26 +0000
- Accept-language: zh-CN, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Y9NZXMXyJlhdkvb/UfNppfnwRORp6eLFj1F6loDhpuY=; b=K3ZOyTQJIGYsEkSqQAk1aZE3Sl7EXjO6d7QLXFSyUpTMTjF9u60wNsvkyv8Gxas1VX8t3JajliTCGG2jowLH8eW3K/zOp8HmcZz6awUAmLY7xehxRQuEVnmuJBPUqOTvPQSmRUSKu7q2FvyD6ecpSaKl34uE66rpb6WkRWNS+qj7t1rJCv2GA5jYiKZ1ofi6GsgtXtJ7+RregRZ0ucW2VlWleQCbxbPyAFtudwP5yv3AYjGsPgzxoiNXBUW61S0aHWMkJxNDIggrzPfXAW0Y4Rw6X9YpLGmz5NWjKG/ZmG0IwwOcovOC8+yLGRejc43mOZpIiO1BAA3pbSccxKytig==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ip9LUN/K2iryNQJEkxtRO4ZFz7U0TneV8ZLsP3nt+Xpu0VB32+pKKrqmzud45fufElsrfnrGAb00zNJER5UC79j4Q9aRydgleMKFsdaqYZLRV7VmuhkSMHeR4QXgpPt6Kar7sI0e1PihRvF2MWAROcjuu7h9YIKpdnyHC8Pv9nrWg+KxbHxuS3HRV9z2qfpAGDGTzNxmdYYrG9K6nSHfC2kvF6/mKZ5SeAa7hqovdRu0DAowfFh2825cEjhObJFOtxCuBoxQoBznlsmLFOQXvD5ZQuREonraqLmeyhmeMisJQ4vNuTu2m6LB7+00Igdj9Ti2O2b2pWTG1hbljRkeaw==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Wei Chen <Wei.Chen@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Thu, 20 Apr 2023 12:48:52 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHZc3rmEF3WFnogck6f7H8jIMmqw680I9wAgAAAs+A=
- Thread-topic: [PATCH v3 02/17] xen/arm: implement helpers to get and update NUMA status
Hi Jan,
> -----Original Message-----
> From: Jan Beulich <jbeulich@xxxxxxxx>
> Subject: Re: [PATCH v3 02/17] xen/arm: implement helpers to get and update
> NUMA status
> > ---
> > v2 -> v3:
> > 1. Rename the first entry of enum dt_numa_status as DT_NUMA_DEFAULT.
> > 2. Make enum dt_numa_status device_tree_numa as __ro_after_init and
> > assign it explicitly to DT_NUMA_DEFAULT.
> > 3. Update the year in copyright to 2023.
> > 4. Don't move the x86 numa_disabled() and make Arm's numa_disabled()
> > a static inline function for !CONFIG_NUMA.
> > v1 -> v2:
> > 1. Use arch_numa_disabled to replace numa_enable_with_firmware.
> > 2. Introduce enumerations for device tree numa status.
> > 3. Use common numa_disabled, drop Arm version numa_disabled.
> > 4. Introduce arch_numa_setup for Arm.
> > 5. Rename bad_srat to numa_bad.
> > 6. Add numa_enable_with_firmware helper.
> > 7. Add numa_disabled helper.
> > 8. Refine commit message.
> > ---
> > xen/arch/arm/include/asm/numa.h | 17 +++++++++++
> > xen/arch/arm/numa.c | 50 +++++++++++++++++++++++++++++++++
> > 2 files changed, 67 insertions(+)
> > create mode 100644 xen/arch/arm/numa.c
>
> While I was Cc-ed on this one, neither the diffstat nor any possible remarks
> make clear whether anything is expected of me here.
Sorry for the confusion. I also thought of this when sending the email but
eventually decided to add you in the Cc as you made some correct and helpful
comments in v2 [1], so I think it is a good manner to add you so that you would
know all your (correct) remarks are addressed.
Thanks for reviewing the series.
[1]
https://patchwork.kernel.org/project/xen-devel/patch/20230110084930.1095203-3-wei.chen@xxxxxxx/
Kind regards,
Henry
>
> Jan
|
