[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 05/16] util/vhost-user-server: rename refcount to in_flight counter
- To: Stefan Hajnoczi <stefanha@xxxxxxxxxx>, qemu-devel@xxxxxxxxxx
- From: Philippe Mathieu-Daudé <philmd@xxxxxxxxxx>
- Date: Thu, 20 Apr 2023 10:18:45 +0200
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Marcel Apfelbaum <marcel.apfelbaum@xxxxxxxxx>, Fam Zheng <fam@xxxxxxxxxx>, Julia Suvorova <jusual@xxxxxxxxxx>, Hanna Reitz <hreitz@xxxxxxxxxx>, Daniel P. Berrangé <berrange@xxxxxxxxxx>, Paolo Bonzini <pbonzini@xxxxxxxxxx>, Coiby Xu <Coiby.Xu@xxxxxxxxx>, Paul Durrant <paul@xxxxxxx>, Ronnie Sahlberg <ronniesahlberg@xxxxxxxxx>, Eduardo Habkost <eduardo@xxxxxxxxxxx>, Juan Quintela <quintela@xxxxxxxxxx>, "Michael S. Tsirkin" <mst@xxxxxxxxxx>, Stefano Garzarella <sgarzare@xxxxxxxxxx>, Anthony Perard <anthony.perard@xxxxxxxxxx>, Kevin Wolf <kwolf@xxxxxxxxxx>, "Richard W.M. Jones" <rjones@xxxxxxxxxx>, Richard Henderson <richard.henderson@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx, qemu-block@xxxxxxxxxx, "Dr. David Alan Gilbert" <dgilbert@xxxxxxxxxx>, Peter Lieven <pl@xxxxxxx>, eesposit@xxxxxxxxxx, Aarushi Mehta <mehta.aaru20@xxxxxxxxx>, Stefan Weil <sw@xxxxxxxxxxx>, Xie Yongji <xieyongji@xxxxxxxxxxxxx>, David Woodhouse <dwmw2@xxxxxxxxxxxxx>
- Delivery-date: Thu, 20 Apr 2023 08:19:02 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 19/4/23 19:28, Stefan Hajnoczi wrote:
The VuServer object has a refcount field and ref/unref APIs. The name is
confusing because it's actually an in-flight request counter instead of
a refcount.
Normally a refcount destroys the object upon reaching zero. The VuServer
counter is used to wake up the vhost-user coroutine when there are no
more requests.
Avoid confusing by renaming refcount and ref/unref to in_flight and
inc/dec.
Reviewed-by: Paolo Bonzini <pbonzini@xxxxxxxxxx>
Signed-off-by: Stefan Hajnoczi <stefanha@xxxxxxxxxx>
---
include/qemu/vhost-user-server.h | 6 +++---
block/export/vhost-user-blk-server.c | 11 +++++++----
util/vhost-user-server.c | 14 +++++++-------
3 files changed, 17 insertions(+), 14 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@xxxxxxxxxx>
|