[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN v5 02/10] xen/arm: Typecast the DT values into paddr_t
- To: Ayan Kumar Halder <ayankuma@xxxxxxx>, Ayan Kumar Halder <ayan.kumar.halder@xxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Michal Orzel <michal.orzel@xxxxxxx>
- Date: Wed, 19 Apr 2023 18:00:17 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Y6Kh9SVHgRW+NFSRH3uXf1Z891SUPvWW+uA5beSDbuY=; b=XKJhau+jVA42qvGa52LNxQUrl7deNM0uMOm+sd2ljxS4UbVblGqmoERUD5oejbGQm6p5CjjZoFCHQeebrSeQE+Wku0J74nDlC14aS2pF0lEb+kflvtzt4Xe7MwgPuPHfuDSmcF2LP5yfsjr6XWUkU5YuJjRk1XKb1ODnSssg8WKlfdkYcX6uxP7sWJGWhTi+fILu85MWItYJwJlcXRkTZx6vR+2AKF9pYOK2EF0Ddtg7aZuTIqDKw/7L0Lbh6ST+U0O/yftzJBxeV16OoCyfz2nHesFtUMlDa1rzz/B4YbSQHA1pvG69Xip5iPsi23Ic6Zs/7Hr6oHzhK6UtOCeZDw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lKFXGndJakPwVwcqWTjcZfCEJRw0nmGbatqukqCg0ISANFEHgCKlqZL7CxMHoBKSL2W0DwXNUVdCUCo8YNBGkkRnIWGimiTKueilDvMfcmUYINUlFn2CflkSIMDOlbI2/9nKMr6vfom37crCG40gAzWWEGKEk52c0gssvg4VBRoiXlEIhnwpmfKGizAsHpYAqOkPLqJQskWz0kA1Y63mkN0p9g/8MdMiUv5NVlSmsTe8Cy1OYa+zN0yUJO3uy36c694gxU+SqMvfpyVPrG0LVeDhtuZxaoSVr6+d+PYpZsoFx+3p3MgCu7EgkwlNqs+U2mXzi7JKUkPYuhUmw/JfXA==
- Cc: <sstabellini@xxxxxxxxxx>, <stefano.stabellini@xxxxxxx>, <julien@xxxxxxx>, <Volodymyr_Babchuk@xxxxxxxx>, <bertrand.marquis@xxxxxxx>, <andrew.cooper3@xxxxxxxxxx>, <george.dunlap@xxxxxxxxxx>, <jbeulich@xxxxxxxx>, <wl@xxxxxxx>, <rahul.singh@xxxxxxx>
- Delivery-date: Wed, 19 Apr 2023 16:01:30 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
Hi Ayan,
On 19/04/2023 17:12, Ayan Kumar Halder wrote:
>
> On 19/04/2023 14:19, Michal Orzel wrote:
>> Hi Ayan,
>
> Hi Michal,
>
> ...
>
>> --- /dev/null
>> +++ b/xen/include/xen/libfdt/libfdt-xen.h
>> @@ -0,0 +1,55 @@
>> +/*
>> + * SPDX-License-Identifier: GPL-2.0-only
>> Our CODING_STYLE says:
>> New files should start with a single-line SPDX comment, ..., e.g.
>> /* SPDX-License-Identifier: GPL-2.0 */
>>
>> For me it would be perfectly fine to do as you did but it is not what our
>> docs state
>> (i.e. single-line comment). It might be that we need to modify CODING_STYLE
>> instead.
>
> Just to be clear, this is what we should have (as Julien had earlier
> suggested to use **GPL-2.0-only** )
I used GPL-2.0 just for example. We want of course GPL-2.0-only.
>
> diff --git a/xen/include/xen/libfdt/libfdt-xen.h
> b/xen/include/xen/libfdt/libfdt-xen.h
> index 3296a368a6..cad7ad3bfb 100644
> --- a/xen/include/xen/libfdt/libfdt-xen.h
> +++ b/xen/include/xen/libfdt/libfdt-xen.h
> @@ -1,6 +1,5 @@
> +// SPDX-License-Identifier: GPL-2.0-only
You should use /* */ style instead of //
> /*
> - * SPDX-License-Identifier: GPL-2.0-only
> - *
> * xen/include/xen/libfdt/libfdt-xen.h
> *
> * Wrapper functions for device tree. This helps to convert dt values
>
> - Ayan
>
~Michal
|
