[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 1/3] xen/ELF: Fix ELF32 PRI formatters
- To: Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Ross Lagerwall <ross.lagerwall@xxxxxxxxxx>
- Date: Tue, 18 Apr 2023 16:14:57 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=OTnlHU1fFwShJQqPzdH7gtEcjZ3s249B0e2b45mwTNg=; b=O5TMVSiEb9XhMg0Ar3W3mDl6hnCGnRvb+QMQtoChZzAsaiXpsZUA8xj3VMMXcf97DLGfy7mFj9kYk8BP8ckaJi8A3pBFOUDtKNZKLJdmVghid9uEdm+TUzJTMFY1rnqCZMad0h76VH3XWA7qdmj970F5UnS3PnoddEwg9Ohe307GLXXKXehclEMymxx/rvTr0DpjCxZ0hgaRz8WhkxdG7x0s7aUSGKUVxuMBE86oM14mCbn94juEL1sJiPIwwrud8X7WtpPw/kDQzqPgiml1b1CXmBYPCXRoj2uZ0H0Bno9mDJHtDczbQWXd2csP70hewEHbOewRUnvQ64NJuyR/5A==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YzoDgSrEJcutBWnAqA7g3qMpzD9m+hS00FrlEu7uffGcoQOM1faComVlO12gFz5CCfT60gIWhha79i3ywrWN/izy/EA6446otRAg5ppW3c2P1iAN1ZYVcXFN7V4oa5fqkYjWQN4KPs1a5cAHcriedPqmOpJm+SwvX46Nw+mA3U368nsbeFpwUgIzMAmBWvHjP6k/gz1Cl1L4665ILVJuR2bwQnxpIZsVqU4Jy3cQVvkNYP3DEF69d35MNyrKP001R9fmvZ1MPZCN6Jy+PX1j2fsn0wQvCCXnPLLr76m6M1AJBSk9r0D9ad5j1qb9emb39Z7jx9qmche9beVbPxUSrg==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Roger Pau Monne <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
- Delivery-date: Tue, 18 Apr 2023 16:15:10 +0000
- Ironport-data: A9a23:MkmB6a8cy1VQ7AsfzzPODrUDG3+TJUtcMsCJ2f8bNWPcYEJGY0x3y WIdCGmGbqrfM2Hyfoh+b4W1oEkG7ZLdnIJrHlBsqyA8E34SpcT7XtnIdU2Y0wF+jCHgZBk+s 5hBMImowOQcFCK0SsKFa+C5xZVE/fjUAOG6UKicYXoZqTZMEE8JkQhkl/MynrlmiN24BxLlk d7pqojUNUTNNwRcawr40Ire7kI+1BjOkGlA5AdmOakb5AW2e0Q9V/rzG4ngdxMUfaEMdgKKb 76r5K20+Grf4yAsBruN+losWhRXKlJ6FVHmZkt+A8BOsDAbzsAB+v9T2M4nQVVWk120c+VZk 72hg3ASpTABZcUgkMxFO/VR/roX0aduoNcrKlDn2SCfItGvn9IBDJyCAWlvVbD09NqbDklH5 O0eEW4dPymqxOK5h+74cPVwlOgseZyD0IM34hmMzBn/JNN/G9XvZvuP4tVVmjAtmspJAPDSI dIDbiZiZwjBZBsJPUoLDJU5n6GjgXyXnz9w8QrJ4/ZopTWCilUujNABM/KMEjCObd9ShV3eo mvJ8n7mCxUeHNee1SCE4jSngeqncSbTAdpOS+Php6A26LGV7jA1J0MRCQGZmPqWhl60etBEc W0QuSV7+MDe82TuFLERRSaQonSJoxodUNp4CPAh5UeGza+8yxaUAC0IQyBMbPQitdQqXno62 1mRhdTrCDdz9rqPRhq19bCStzq+fzcUKWwqYjUNRg8IpdLkpekblQnTR9xuFKq0iNzdGjzqx T2O6i8kiN07j9MP1qi91UDKhXSrvJehZjAy4gLbT2e09DRTbYSuZ5GrwVXD5PMGJ4GcJnGLs WIYgcGY4KYLBIuUiS2WaOwXGfei4PPtGCLYqU5iGd8m7TvFxpK4VYVZ4TU7KEI3NM8BIGXte BWK5l8X44JPNny3a6Mxe5i2F8kh0annE5LiS+zQad1NJJN2cWdr4R1TWKJZ5Ei1+GBErE31E c3znRqEZZrCNZla8Q==
- Ironport-hdrordr: A9a23:xOhLIqMvAv2wYMBcTuqjsMiBIKoaSvp037BL7TEVdfUxSKb0qy nAppgmPHPP5wr5IUtQ4OxoW5PwI080l6QU3WB5B97LYOCBggWVxepZnOjfKlPbehEWwdQtsZ uII5IUNDQpNykAsS8h2njfLz/8+qjhzEl1v5an856yd3ARV51d
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Msip_labels:
- Thread-index: AQHZcSYeWIT0W+bO3UKuBt801j9Sd68vbuAAgAAVJYCAAbqv2A==
- Thread-topic: [PATCH v2 1/3] xen/ELF: Fix ELF32 PRI formatters
> From: Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>
> Sent: Monday, April 17, 2023 2:47 PM
> To: Jan Beulich <jbeulich@xxxxxxxx>; Xen-devel
> <xen-devel@xxxxxxxxxxxxxxxxxxxx>
> Cc: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>; Ross Lagerwall
> <ross.lagerwall@xxxxxxxxxx>; Stefano Stabellini <sstabellini@xxxxxxxxxx>;
> Julien Grall <julien@xxxxxxx>; Volodymyr Babchuk
> <Volodymyr_Babchuk@xxxxxxxx>; Bertrand Marquis <bertrand.marquis@xxxxxxx>;
> Roger Pau Monne <roger.pau@xxxxxxxxxx>; Wei Liu <wl@xxxxxxx>
> Subject: Re: [PATCH v2 1/3] xen/ELF: Fix ELF32 PRI formatters
>
> On 17/04/2023 1:31 pm, Jan Beulich wrote:
> > On 17.04.2023 14:13, Andrew Cooper wrote:
> >> --- a/xen/common/livepatch_elf.c
> >> +++ b/xen/common/livepatch_elf.c
> >> @@ -310,12 +310,12 @@ int livepatch_elf_resolve_symbols(struct
> >> livepatch_elf *elf)
> >> break;
> >> }
> >> }
> >> - dprintk(XENLOG_DEBUG, LIVEPATCH "%s: Undefined symbol
> >> resolved: %s => %#"PRIxElfAddr"\n",
> >> + dprintk(XENLOG_DEBUG, LIVEPATCH "%s: Undefined symbol
> >> resolved: %s => 0x%08"PRIxElfAddr"\n",
> > I don't see what's wrong with using %# here (and below); I also don't see
> > what value it has to zero-pad to 8 digits when the printed value either
> > is far below 4G (when representing just a section offset) or likely far
> > above (when representing a real address on 64-bit). But once again I'll
> > leave judging to the maintainers.
>
> Hmm - I could be persuaded to drop everything in livepatch_elf.c. I
> guess that makes it more consistent with the 64bit side too.
Indeed, I would prefer without the changes in xen/common/livepatch_elf.c
With those dropped,
Reviewed-by: Ross Lagerwall <ross.lagerwall@xxxxxxxxxx>
|
