Re: [PATCH v5 00/12] SVE feature for arm guests

[Julien Grall <julien@xxxxxxx>]

On 18/04/2023 14:13, Bertrand Marquis wrote:
> Hi Luca,
Hi,

> On this serie I would like to open a discussion on how to handle the vector size
> and the corresponding command line / configuration / device tree parameters.
>
> In general the user must either give a vector size it wants or has a solution to
> just request the maximum supported size.
>
> In the current implementation if a size bigger than the supported one is 
> provided:
> - we silently disable SVE for dom0
> - we silently disable SVE for dom0less
> - we do not create a guest when done through tools
>
> This is not completely coherent and i think we should aim for a coherent 
> behaviour
> unless we have arguments for this status.
+1.

> Is there any good reason to silently disable for Dom0 and dom0less only ?
>
> I see some possible solutions here:
>
> - modify parameter behaviour to use the supported size if parameter is bigger 
> than
> it. This would at least keep SVE enabled if a VM depends on it and could 
> simplify
> some of the handling by using 2048 to use the maximum supported size.
My concern with this approach and the third one is the user may take 
some time to realize the problem in the xl.cfg. So...
> - coherently stop if the parameter value is not supported (including if sve is
> not supported)
... this is my preferred approach because it would be clear that the 
value passed to Xen is bogus.
Cheers,

--
Julien Grall