[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] x86: cpu{id,}_policy_updated() can be static
- To: Jan Beulich <jbeulich@xxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>
- From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Date: Tue, 18 Apr 2023 11:39:18 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xpgpD7oc+ofi0DbdBk9Tn5P++fBjIyyFxvDUqif+9Oo=; b=I/fU2CkUow4UtGidMk5Zt3c30K5iulB8JvrEX2wPOeeFP1Ex8LjolcXhu8wPwTwd6sjrEvqRmDs3TuL4YrvgoeqdXLRMnUuaN+OSM9lptSbRHKOKehTucjbMdtyhjTxFzwfXzmAN2ThsHb2a5RtjiTPbZoraJL2IsXgjfsm7yxM1b4DuAgSpVcs4S4yvb9HPzi76UZF+AV+s3vqbLvNwD388mVv+dMaoIjtWfqvARrBNz+BlPCZ/Ai1myMEZXmVpxbVfKwXJDctVIzWmNK7hfEvQT/idmdZ/FtI9M8V1c441vlqdVjHk212wSTzS4uTNEItjwyYGPtiQHh7ga4lV1A==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=L4BwrApIp0zu5MoEfOzvULjK8QJmDT8Dd+KrRcGdNcUgQF3NYvgMxrh7/TCkdvCFR4tNZvaqVQP7jvnEw8xGeq2rbEEpk59lTKLUpSTQQjjyWsiLNAJ/CHDonaz9dcoiHNMC4OlzgSs3Nn/dLa47vOTETlSFz1rZh68fNppk1qUSxm5hd0F3JhZYyw+OuwA1+kkt63gXdjtiBZA0NHrLbBFjKiVgiS60Hfdb7PxWiIEzvAnsf/KwIW7az+CKdgx5LLvIcUuxB/PG5z7kIKYf8SpN1RfsVHZ9wUqyCdyDDxqb1CCafsPLwtta/whnbGgkO5HQUl//LO/NglUhpZdaWQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
- Delivery-date: Tue, 18 Apr 2023 10:39:37 +0000
- Ironport-data: A9a23:Ff0bhKiuVwBRMGuCtQwjIUPLX161TREKZh0ujC45NGQN5FlHY01je htvXTqPaKrcNDbyetEiPYSx8U9Vu5KAn4VkSwo9qn03ECIb9cadCdqndUqhZCn6wu8v7q5Ex 55HNoSfdpBcolv0/ErF3m3J9CEkvU2wbuOgTrWCYmYpHlUMpB4J0XpLg/Q+jpNjne+3CgaMv cKai8DEMRqu1iUc3lg8sspvkzsy+qWj0N8klgZmP6sT4AaOzyN94K83fsldEVOpGuG4IcbiL wrz5OnR1n/U+R4rFuSknt7TGqHdauePVeQmoiM+t5mK2nCulARrukoIHKN0hXNsoyeIh7hMJ OBl7vRcf+uL0prkw4zxWzEAe8130DYvFLXveRBTuuTLp6HKnueFL1yDwyjaMKVBktubD12i+ tQyLGwqZSuPtdum74PmZNFOo8sgL+jCadZ3VnFIlVk1DN4AaLWaGuDhwoYd2z09wMdTAfzZe swVLyJ1awjNaAFOPVFRD48imOCvhT/0dDgwRFC9/PJrpTSMilEvluGybrI5efTTLSlRtm+eq njL4CLSBRYCOcbE4TGE7mitlqnEmiaTtIc6TeXlp6Ew2gPJroAVIE0VXH7is9K5sRWBa8h2J EsY0zAuqqdnoSRHSfG4BXVUukWsvBQRRt5RGO0S8xyWx+zf5APxLngJSHtNZcIrsOcyRCc2z RmZktXxHzttvbaJD3WH+d+8sjeaKSUTa2gYakc5oRAt5tDipMQ4iUvJR9M6Saqt1ISqR3f33 iyAqzU4i/MLl8kX2q6n/FfBxTWxupzOSQ1z7QLSNo640j5EiEeeT9TAwTDmATxocO51knHpU KA4pvWj
- Ironport-hdrordr: A9a23:e6bQGKve0dDJy3ahtfg3rKPB7skDpdV00zEX/kB9WHVpm62j5r +TdZEgvnXJYVkqNE3I5urwQZVoLUmwyXc32/hrAV7aZnidhILKFvAf0WKd+VPd8kTFn4ZgPM FbEpSWY+eeMbEVt7eG3OFJeexQpuVuAsqT9ITjJyoHd3AJV0mAhT0YNu/iKDwPeOCwP+tfKH J/jPA3wgZJmR4sH6CGOkU=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 18/04/2023 11:22 am, Jan Beulich wrote:
> On 18.04.2023 11:42, Roger Pau Monné wrote:
>> On Tue, Apr 18, 2023 at 11:35:41AM +0200, Jan Beulich wrote:
>>> The function merely needs moving earlier in the file to avoid the need
>>> for a forward declaration. While moving it, also rename it following the
>>> recent folding of CPUID and MSR policies.
>>>
>>> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
>> Acked-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
> Thanks.
>
>> We might also want to rename the hvm_function_table hook.
> I did notice this, but it seemed orthogonal enough to not do it right here.
>
>> One minor comment below.
>>
>>> --- a/xen/arch/x86/domain.c
>>> +++ b/xen/arch/x86/domain.c
>>> @@ -288,6 +288,16 @@ void update_guest_memory_policy(struct v
>>> }
>>> }
>>>
>>> +/*
>>> + * Called during vcpu construction, and each time the toolstack changes the
>>> + * CPUID configuration for the domain.
>> The comment also needs to be updated to contain CPUID/MSR or some
>> such now.
> This isn't the case just yet aiui, but will be soon. Saying something
> like "MSR configuration" would read misleading to me, so I'd prefer "CPUID
> etc configuration", if that's okay with you (and Andrew).
Technically it already contains one MSRs worth of configuration, which
is misc info and cpuid faulting. It will imminently contain two.
Please use "CPU policy" here, which I think will cover things suitably.
~Andrew
|
