[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] x86emul/fuzz: correct header (symlink) dependencies
- To: Jan Beulich <jbeulich@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Date: Mon, 17 Apr 2023 09:09:10 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=nJKWWJiu8fJzuR/l1aOE4WNY5JuaYmW1hUX683p7PbU=; b=F7ntzVVdOnEuuE5NSQy278jhw0dFVhVe2AznnffgMNJ2pTx6aWnc1tOQWhFY/D/Kqxo7vspFLjffQQu437xGs/XyQOCo757d8ZETzghHTHpmJRU55+pnqJj98RSqzNEU4z93dTRjPZoL0nZ6SHPFC1aqwlT2rLQAgXK70Jfgy3vshYLQnIKZgBdeg2a2H+V0L2rAwIPyiM/NdgHc6gNEafzxz3fkReNi+dc3spT8ouXFF689pwweFt7IS1FuWH8mDAReyfK8DM9lwtMcFQwHTKGsf0+U9joFC1DcO+kNMLKJAGPRuNOg6bg4lY3dhtFz0OKgduA6qT7x1AUyMQK4Tw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LVUEg0D1fj1HodBGpoFyN72o5rAp8seBVel8YNo5kiRwAtIuiCsekQOiVkd7rNKKWu3917W3Ofaax9XCRzlNIoql9eol4x/h31jHPD0q3+jAo2gW/XQPBEGhpjKdpe4mUY8MpTTrvIDQ2/yyUz7GKYTQz9h3VMcO3INUK+QQ7a9IhyJ8zcB+FcdWvRTwxfB21yXhLKWq1XjIbGmz00HPMRqHoWc8t+BYeChoZkF/TxLoCg2F4oLEPCdgFHR5L2FCBMi9lw/ZLFNbmcDaFlMBvWQQcUHX/keikALJD7EhTaNtvKteOzL4c4Xxfff8YfDtzpN6RrlUc6+BiWKssQ1nmw==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Wei Liu <wl@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Delivery-date: Mon, 17 Apr 2023 08:09:27 +0000
- Ironport-data: A9a23:3fpC86uiMR340VE7l3xwXEJGlufnVHRfMUV32f8akzHdYApBsoF/q tZmKWmEOKyLa2KjLYwjbI+1/U8Gu5TVzd5jSwM4qHtmFS8b+JbJXdiXEBz9bniYRiHhoOCLz O1FM4Wdc5pkJpP4jk3wWlQ0hSAkjclkfpKlVKiffHg3HVQ+IMsYoUoLs/YjhYJ1isSODQqIu Nfjy+XSI1bg0DNvWo4uw/vrRChH4bKj6Vv0gnRkPaoQ5AOHySFPZH4iDfrZw0XQE9E88tGSH 44v/JnhlkvF8hEkDM+Sk7qTWiXmlZaLYGBiIlIPM0STqkAqSh4ai87XB9JFAatjsB2bnsgZ9 Tl4ncfYpTHFnEH7sL91vxFwS0mSNEDdkVPNCSDXXce7lyUqf5ZwqhnH4Y5f0YAwo45K7W9yG fMwBCIsbS2jlbyK2Lu2W/lJieoREMjwM9ZK0p1g5Wmx4fcOZ7nmG/mPz/kImTA6i4ZJAOrUY NcfZXx3dhPcbhZTO1ARTpUjgOOvgXq5eDpdwL6XjfNvvy6Pk0oujP6xYLI5efTTLSlRtm+eq njL4CLSBRYCOcbE4TGE7mitlqnEmiaTtIc6TeXlqKE20AzNroAVIFpOZ2C7k/bisGu/HOlhI Vwk1QUSi6dnoSRHSfG4BXVUukWsvBQRRt5RGO0S8xyWx+zf5APxLngJSHtNZcIrsOcyRCc2z RmZktXxHzttvbaJD3WH+d+8sjeaKSUTa2gYakc5oRAt5tDipMQ5iELJR9M7TKqt1IWpSXf33 iyAqzU4i/MLl8kX2q6n/FfBxTWxupzOSQ1z7QLSNo640j5EiEeeT9TAwTDmATxodu51knHpU KA4pvWj
- Ironport-hdrordr: A9a23:jdGmna3WUlku9oDHr7cE0AqjBa9xeYIsimQD101hICG9Lfb0qy n+pp4mPEHP4wr5OEtOpTlPAtj4fZquz+8T3WB3B8beYOCGghrTEGgG1+ffKlLbak7DH4JmpM Jdmu1FeabN5DtB/LjHCWuDc+rIqePvmM7IuQ6d9QYUcegDUdAe0+4TMHf+LqQZfnghOXN0Lu v/2iIRzADQBUj/I/7LTkXsGIP41q/2vaOjRSRDKw8s6QGIgz/twLnmEyKA1hNbfyJTzawk+W 3llRW8wqm4qfm0xjLVymeWtv1t6Zfc4+oGIPbJptkeKz3qhArtTIN9W4eatDRwjPCz5E0smN zspQ5lG8ho8Xvecky8vBOo8Qj91zQF7WPk1Daj8DbeiP28YAh/J9tKhIpffBecw008vOtk2K YO+26CrZJYAT7JgSy4vrHzJltXv3vxhUBnvf8YjnRZX4dbQLhNrbYH9EcQNJsbBir15K0uDe ErJsDB4/R9d0+cchnizyJS6e3pek52MgaNQ0AEtMDQ+z9KnEphx09d/8AblmdozuNLd7B0o8 D/doh4nrBHScEbKYhnAv0afMexAmvRBTrRLWO7Oz3cZeE6EkOIj6SyzKQ+5emsdpBN5oA1go 79XFRRsnN3U17yCPeJwIZA/nn2MSSAtAzWu4NjDqVCy/jBrOKBC1zGdLluqbrvnxwnOLyZZx 7pU6gmRMMKLgPVaPJ0NkPFKt9vwEIlIb4oU+YAKiOzS/3wW/3XX8zgAYDuzenWYH8Zc1K6JE c/dx7OA+gFxnyXexbD8W3ssjXWCwPCwa4=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 17/04/2023 8:54 am, Jan Beulich wrote:
> A use of $(x86_emulate.h) was introduced (mirroring what the testharness
> has) without realizing that no such variable exists here. (Re)name the
> variable (to) "private.h", which better expresses what is included which
> way.
>
> Note that because of automatic dependencies tracking, unlike in the test
> harness no $(x86.h) variable is needed here - we solely need explicit
> dependencies for files which need symlinks created.
>
> Fixes: 9ace97ab9b87 ("x86emul: split off opcode 0f01 handling")
> Reported-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
Acked-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
|
