[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v7 3/5] xen/arm64: mm: Introduce helpers to prepare/enable/disable the identity mapping


  • To: Julien Grall <julien@xxxxxxx>
  • From: Luca Fancellu <Luca.Fancellu@xxxxxxx>
  • Date: Mon, 17 Apr 2023 07:46:21 +0000
  • Accept-language: en-GB, en-US
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=cItfq53Pg6byDbdG9uVNgWkA18BfqckFsGFCdIja904=; b=MjU6dRcHMMuX7FimzFoliZL2rTdY9mXQRDDNLCHENzR7qQbnnFRhLxKBW6Om9K4TUB+sqF1+tKG/qWtv73hfMwChXOu8pQVTe3D202n8v87UcKKmCU8c1EoLRW/Uoa9sGgBRXuCYR2k7R2d4wgxmk9b2JEIYzHymVMRLr+0mdSkqqxJZgZijGqx2BxWCoUXaKBuHVQ13WiwBFRkEBloUYBXO5Oy9L8/f/tBDrXKfrnGDKeUkzikkh/fwrIRqDMdNoLdN/X+Xi9VjuI39tZ65UxKKPsUCMdfU0SlfPaDW/M0FzwcLUfTZbRCo6ZE5aLfF9ziZBxITezuPZ5T9S4CWsQ==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=C4GQrCpYpWN5Y8+leMhdtNcSfTJ2AzIVrkWMrF1tUn//7ZGnK9qfDjjNM6iVnvZw9Oi/MQaNRGf+3pUeWjmt4pGPEfXE6uDK7SeG4cdxmn2QwbJd+u0QhInQZSiqzHv0PNUwL2EByzr+sUUrj6jFWGobsheGV98IOl+moktMAs4Tf5fYAEJ8Q0W4ZSdZwTZgvmJwN4VuYL3SnaeFfjjvycPfXfU2TkojJVWu/pLT9JFgzBNYtyAxLL041a/VUxc1wXBYhysB+L13Dp3T/eiQZAvfwh14JditAH3qRWQIBa+umdAHloMfjwM5NvX4SO8bBAq4FuIsTQha2rPOsttCZQ==
  • Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
  • Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, "michal.orzel@xxxxxxx" <michal.orzel@xxxxxxx>, Julien Grall <jgrall@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
  • Delivery-date: Mon, 17 Apr 2023 07:47:35 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Nodisclaimer: true
  • Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
  • Thread-index: AQHZcHBP636VZKQlJkWnTIQrYG+QeK8vIIIA
  • Thread-topic: [PATCH v7 3/5] xen/arm64: mm: Introduce helpers to prepare/enable/disable the identity mapping


> On 16 Apr 2023, at 15:32, Julien Grall <julien@xxxxxxx> wrote:
> 
> From: Julien Grall <jgrall@xxxxxxxxxx>
> 
> In follow-up patches we will need to have part of Xen identity mapped in
> order to safely switch the TTBR.
> 
> On some platform, the identity mapping may have to start at 0. If we always
> keep the identity region mapped, NULL pointer dereference would lead to
> access to valid mapping.
> 
> It would be possible to relocate Xen to avoid clashing with address 0.
> However the identity mapping is only meant to be used in very limited
> places. Therefore it would be better to keep the identity region invalid
> for most of the time.
> 
> Two new external helpers are introduced:
>    - arch_setup_page_tables() will setup the page-tables so it is
>      easy to create the mapping afterwards.
>    - update_identity_mapping() will create/remove the identity mapping
> 
> Signed-off-by: Julien Grall <jgrall@xxxxxxxxxx>
> 

Hi Julien,

Reviewed-by: Luca Fancellu <luca.fancellu@xxxxxxx>




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.