[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH 1/3] xen/arm: vpl011: Fix misleading comments
- To: Michal Orzel <michal.orzel@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Henry Wang <Henry.Wang@xxxxxxx>
- Date: Wed, 12 Apr 2023 06:21:29 +0000
- Accept-language: zh-CN, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3pOZzwPMMV1DuJnSfPi/4WZieEoZhtGCWT5AFri2azU=; b=OJPgqgWY4566BH2p7ZGP2/XgrSKonYA0YqqG0utqf3bhN+cbHZ63bwnspB0HZdtzAewsXjWZBgCaZo9QxaHlrnClBBkmdvLoEsd66Odw0aAx7mHJBWdr0k6S03g/FT2QVd9o9mJcXjFgVL8CZKkSojb/0NLIFDoHe/vUBsbmCaYf9lRtwACanX/1QqyA4S02SiU4eqQSLb6hjJ5aYD5y5+4NCE5jjQCwnyCAjrk/2IgLVyf73+l90zqY7ovNdBKGyOv6ogdT2T4xF3HBFxwDBKs14sxPyGxJ4gwOBkMZ/TXU3CrRtguyYLVsvvMHlLmrK4cxk+TvHA/pAIxtascrDA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=L5fdIfojZSLOEm8yVjlvrglenTFRKAnLe4InAyul0DxS5c7xj5p266IGRD+s8eB/t2Y6hev0ZQlbWNDWGBHPNxp4yfNzP8q4O86MzPSCmr2W6j9WeOGhOsWQhIc/KHtuw/JPCfMky4ClBd4RdZlod2wtGFb+N8b9IHJozXDxb+6g2DzgdxybbZSzKcSZWCqNDxYXyjz6jrADoKCkQcPA0UNgO0zQrJRgEp4cGOj2RR2IQc8uJiUYk0ItncegTEUpbTga6Pfwc3WGOJCaxLKEayAqS+gAV/6Xa1QtZVLFT9PgyMjt1EFlO9stQnZbIhr6IV81pPert3zR67VlPU6X+A==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Delivery-date: Wed, 12 Apr 2023 06:22:02 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHZZ7BiVWY3mibtKkuaZtbP8Fag3a8nPoCg
- Thread-topic: [PATCH 1/3] xen/arm: vpl011: Fix misleading comments
Hi Michal,
> -----Original Message-----
> Subject: [PATCH 1/3] xen/arm: vpl011: Fix misleading comments
>
> In both vpl011_read_data() and vpl011_read_data_xen(), there is a comment
> stating that the guest is expected to read the DR register only if the
> TXFE bit of FR register is not set. This is obviously logically wrong and
> it should be RXFE (i.e. RX FIFO empty bit set -> nothing to read).
>
> Signed-off-by: Michal Orzel <michal.orzel@xxxxxxx>
Reviewed-by: Henry Wang <Henry.Wang@xxxxxxx>
Kind regards,
Henry
|
