[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] x86emul/test: drop bogus .PHONY
- To: Anthony PERARD <anthony.perard@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Wed, 5 Apr 2023 18:16:43 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ED/pJhg31bjLlSP3HBT0D3rUkA+rwZgqc+paNaMixrg=; b=NYLlIQ9/1naOK2VdPAIDzUSt1sq7EoBnWB5XjiaqfNMuYNe7CMy5IbQZCjqzFak63WZKU9g+yP75Rz29eSfFwNImoVpeWSNwx7svXn/ZdMbaGoTwcnIfVRhnXBfBkXxSgaAWQ96XNw/yq+fPh7t3bdF/R2/I1W/9g7JEPbR6pv1RvRcpFLLZSrZMHzkkGtd5QnKUQTCYZMzWEskyU9TBSOaKLHMSF9okZkhpbKa/YnNi7uCERW/MgX0gYnh3/5T5xrlUt6a9mpWq7sQJDmopGHcKPp0sJbdszZ0AsuJcYoYdyNwGCd35qGjC+es51/WnhUzi+ghQjlP6UugBb/4Jow==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=G51r360AJlTIkzmctJlQi5uTONjZ23w2RzfWg1JTOFp2blJGsYMICvGKY2ZsClzGrsggO/ara3CCk7jKC1owO1iRrXIdZNEBqWkp+/Cpj8clc2XeeCERBrOY5l8JUbMGujzsMWrDolQp2xMouNY9nBBrkUbYwZ0d/qoqMBUKA3ywEAnOWGp0aZ0LHDPUHN+zqE7jyOYUIJE5hQkX5ans0NW6nzSScqq69hNc3A0LESlxmYXa50P15wzs8M9LfSTPPVY8mM0vmrQYkCK8maNDk2q23d9k7B2Tj5jnkFhe4OhfH/FkYACz5j/tqrwY8k0Pu4lfzO9yhr9n5OujtNih7g==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Delivery-date: Wed, 05 Apr 2023 16:17:05 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 05.04.2023 17:48, Anthony PERARD wrote:
> On Tue, Apr 04, 2023 at 08:37:55AM +0200, Jan Beulich wrote:
>> x86_emulate is a real (directory) target.
>
> Indeed, x86_emulate is a directory, so having the target in .PHONY
> isn't bogus, but kind of expected in most cases.
>
> Here, the recipe is written with .PHONY been used, as suggest the used
> option "-p" from `mkdir` and "-f" from `ln`.
>
> Without .PHONY, the recipe will never be executed if the directory
> exist. And, if the content of the original x86_emulate directory
> change, the linked directory will never be updated.
>
> So, this patch description needs a reason for removing x86_emulate from
> .PHONY. Is there some kind of bug?
Yes, but it was my brain that was buggy. I deliberately added that
line long ago when converting the symlink to a real dir, and then for
whatever reason thought recently that it was bogus. Right you are,
and I'll revert this change.
Jan
>> --- a/tools/tests/x86_emulator/Makefile
>> +++ b/tools/tests/x86_emulator/Makefile
>> @@ -278,7 +278,6 @@ else
>> run32 clean32: %32: %
>> endif
>>
>> -.PHONY: x86_emulate
>> x86_emulate:
>> mkdir -p $@
>> ln -sf $(XEN_ROOT)/xen/arch/x86/$@/*.[ch] $@/
>
> Cheers,
>
|
