[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v8 7/7] pcmcia: Convert to use less arguments in pci_bus_for_each_resource()



On Thu, Mar 30, 2023 at 07:24:34PM +0300, Andy Shevchenko wrote:

...

> @@ -960,12 +960,9 @@ static int nonstatic_autoadd_resources(struct 
> pcmcia_socket *s)
>        */
>       if (s->cb_dev->bus->number == 0)
>               return -EINVAL;
> -
> -     for (i = 0; i < PCI_BRIDGE_RESOURCE_NUM; i++) {
> -             res = s->cb_dev->bus->resource[i];
> -#else
> -     pci_bus_for_each_resource(s->cb_dev->bus, res, i) {
>  #endif
> +
> +     pci_bus_for_each_resource(s->cb_dev->bus, res) {
>               if (!res)
>                       continue;

As pointed out in the reply to Bjorn's email this hunk needs to be revisited,
since I wrote the documentation for the above call I have started understanding
the deal behind this special treatment for X86 case.

-- 
With Best Regards,
Andy Shevchenko





 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.