[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2] x86/PV: ignore PAE_MODE ELF note for 64-bit Dom0


  • To: Jan Beulich <jbeulich@xxxxxxxx>
  • From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
  • Date: Tue, 4 Apr 2023 12:04:21 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PevfhuB9Pt0w/l3GtYOJ6zG/k37g0KxbE8D4sxkY1qE=; b=OSDS5bsm90d9YFNJLl2qwRi6LdWbDOAGkDNjbVJM14Pb2Uca2u5HDXoaM8YC0Azsh/sfJQFgBO4IHuiqrhiYZrVIIr8GUtyL1MG1CqwLwK5MyvIwfia4R37bBvNQOkyRKQYtGuIfPFmhnAGvA5qJMbz5oKwPJHqD+rQFdDP2TVc2Ep/jLrO5XNff3mBV1oQ/4c8PakM8EMKzhasj5GplkEt5kJgJHVthQZlObU1vIH6PrQF7HxNslWbD8GpjP6oE5A1HKVjqdiixTMg+ZNK/+k+Q1soD0qsHZxYM32UVKYDwZYjiX8A27uUJP+6z1dMHlnOVKMLo3BaGzWtZuexGVA==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fP30eJHQi8VKXJe0tPnSekRi/t+MnesKJZwzkFusYT6vl30Zn5uhhD7b0PX+Zk6kisWYCuSvG8rpuxfoFxC1JrEqpzNx2xDzXFgZzuNGf9OIper592uKSKvoeSmN13Mr+sn1c0u4LakFKLJ4kT0pEy4lpxgks95/enTYSp9YhjQy1DEP+qrzMe1eQZDq6znMTfoeEwCbrP6dX1UfbHKD43HA3UiMXts9BxFXcanYR1w3NO8SFYeYSaRY7KaASxglEE9gMf6QFF59224FIwjPVwXvl0q64seyv1Yi5PtB6+V2WN8Jqa5hsO8UDTbvQd9sdjoHTjWb0GRn4NQhOibz+A==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
  • Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
  • Delivery-date: Tue, 04 Apr 2023 10:05:01 +0000
  • Ironport-data: A9a23:4L8JBq4rgJJCZCjKFrxnNAxRtBnGchMFZxGqfqrLsTDasY5as4F+v mMZCzyOPvmDYWf3c9Egb46zoxsH6pLcm9JkSwNprnoyHi5G8cbLO4+Ufxz6V8+wwm8vb2o8t plDNYOQRCwQZiWBzvt4GuG59RGQ7YnRGvynTraCYnsrLeNdYH9JoQp5nOIkiZJfj9G8Agec0 fv/uMSaM1K+s9JOGjt8B5mr9VU+7JwehBtC5gZlPawT4AeH/5UoJMl3yZ+ZfiOQrrZ8RoZWd 86bpJml82XQ+QsaC9/Nut4XpWVTH9Y+lSDX4pZnc/DKbipq/0Te4Y5iXBYoUm9Fii3hojxE4 I4lWapc6+seFvakdOw1C3G0GszlVEFM0OevzXOX6aR/w6BaGpdFLjoH4EweZOUlFuhL7W5m6 80/CGgtfAy5mLyI452WFvBvo+4zI5y+VG8fkikIITDxK98DGMmGaYOaoNhS0XE3m9xEGuvYa 4wBcz1zYR/cYhpJfFAKFJY5m+TujX76G9FagAvN+exrvC6OnEoojumF3Nn9I7RmQe1PmUmVv CTe9nnRCRAGLt2PjzGC9xpAg8eWxXilAdlDROLQGvhCqkO83FdJKyYtd0qJ/NW2lBGif+p6E hlBksYphe1onKCxdfH/VRClpH+PvjYHRsFdVeY97Wml2qfSpgqUGGUAZjpAc8A98t87QyQw0 V2ElM+vAiZg2JWKTVqN+7HSqim9URX5NkcHbC4ACAEDs9/qpdhqigqVF4gyVqmoktfyBDf8h SiQqzQzjKkSishN0Lin+VfAgHSnoZ2hohMJ2zg7l1mNtmtRDLNJraT0tDA3Md4owF6lc2S8
  • Ironport-hdrordr: A9a23:npkDy6N7m60jLsBcTgWjsMiBIKoaSvp037BK7S1MoH1uA6mlfq WV9sjzuiWatN98Yh8dcLO7Scu9qBHnlaKdiLN5VduftWHd01dAR7sSjrcKrQeAJ8X/nNQtr5 uJccJFeaDN5Y4Rt7eH3OG6eexQv+Vu6MqT9IPjJ+8Gd3ATV0lnhT0JbTqzIwlNayRtI4E2L5 aY7tovnUvaRZxGBv7LYEXsRoL41qT2qK4=
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On Tue, Apr 04, 2023 at 11:19:08AM +0200, Jan Beulich wrote:
> Besides a printk() the main effect is slight corruption of the start
> info magic: While that's meant to be xen-3.0-x86_64, it wrongly ended
> up as xen-3.0-x86_64p.
> 
> Note that no known users exist that would have developed a dependency on
> the bogus magic string. In particular Linux, NetBSD, and mini-os have
> been checked.
> 
> Fixes: 460060f83d41 ("libelf: use for x86 dom0 builder")
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>

Acked-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>

> ---
> RFC: While Linux works fine with the adjustment, I'm not entirely
>      certain of external tools (crash?) having grown a dependency. It
>      may be worth noting that XenoLinux and its forward ports never had
>      this ELF note in 64-bit kernels, so in principle it may be
>      reasonable to expect that no such dependency exists anywhere.
> 
> Prior to "x86/PV32: restore PAE-extended-CR3 logic" that (meaningless
> for 64-bit domains) VM-assist could also be engaged, based on the ELF
> note's value. I expect that change to go in first, at which point the
> description here is going to be correct (in not mentioning this VM-
> assist aspect).

Will look at it now.

Thanks, Roger.



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.