[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] cmdline: document "extra_guest_irqs" upper bound
- To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Tue, 4 Apr 2023 09:37:42 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=A9iXgmTsj+0Rxvl5Ewhk+C1qP1W68DSWKVggTNGwczk=; b=b2moBjgtdKWmeSf+pGQNi7a9hyOV/1n8s+Irq9Suj4upp2azGhTyG3i1AQsdPao4B6xP+U0G7qg37KnUDkZSDEep6w9/QTivXTwY2HHOYM7d+vMu6ZzgZP+5Fusm6kPFMXGoIG8wkTAQJSpzd2yc96VjYaiWe0SQ4HU72i/8O85vOKmne4ClRdGqmSP5pCSj0Uf57dyjBLXe9eUYqQUIRA2y/vAECrX+JWfM07ciXwjSqkNpSDJMctzg4sOKTbr43yPI0iJWxZjw9sEBlXLAcgdwblIUqtEr3aTOlk38dOvEjMXGLdwj/rft/T79YMD4uMKVN9JxYRTSBXBWK3VIVg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CyQ2v5VCAOBCG5+IGWoKhxOJ1219jOEz/0JvInID30pnHeWRk6DDpnJqTGSBY3pFcfmQK7K7GN9cnIp8liFKoQbYON1gq1xonS4pS3T7k/g3HotSPA+7lSj1vtMjafTDCDdXjTIDruMVy/K0CIMZI7w5E5pobGk269SP0Qr3ptoLYxS6JAKfP9O6QQBhkDBy6w8r3YPlJHEssPJA4kPrWVD6TNGK1NuyaJyB1qPPK3hp02+GV0P4L9bpgpWxjFSDF55uNcxm2zMbmVWlv6+4NCh19gHyIXWPj8FK3jwYoVZXRnF02ptq5CjOmuvvli6zcSTa9nye5cRWfmCZGDIB+Q==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Tue, 04 Apr 2023 07:38:08 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 04.04.2023 09:09, Andrew Cooper wrote:
> On 04/04/2023 7:46 am, Jan Beulich wrote:
>> PHYSDEVOP_pirq_eoi_gmfn_v<N> accepting just a single GFN implies that no
>> more than 32k pIRQ-s can be used by a domain. Document this upper bound.
>>
>> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
>
> Acked-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
Thanks, but because of the below I guess I'll make a v2.
>> ---
>> I was uncertain about also introducing a bounds check in code: We don't
>> check for bogus / abusive values elsewhere either.
>
> Normally not, but in this case I suspect it's worth it. Without a
> bounds check, don't we risk wandering off the page?
Indeed we do; in debug builds we hit assertions.
Jan
|
