[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v8 6/7] EISA: Convert to use less arguments in pci_bus_for_each_resource()
 
- To: Mickaël Salaün <mic@xxxxxxxxxxx>,	Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>,	Krzysztof Wilczyński <kw@xxxxxxxxx>,	Mika Westerberg <mika.westerberg@xxxxxxxxxxxxxxx>,	Michael Ellerman <mpe@xxxxxxxxxxxxxx>,	Randy Dunlap <rdunlap@xxxxxxxxxxxxx>,	Arnd Bergmann <arnd@xxxxxxxx>,	Philippe Mathieu-Daudé <philmd@xxxxxxxxxx>,	Niklas Schnelle <schnelle@xxxxxxxxxxxxx>,	Bjorn Helgaas <helgaas@xxxxxxxxxx>,	"Rafael J. Wysocki" <rafael.j.wysocki@xxxxxxxxx>,	Pali Rohár <pali@xxxxxxxxxx>,	"Maciej W. Rozycki" <macro@xxxxxxxxxxx>,	Juergen Gross <jgross@xxxxxxxx>,	Dominik Brodowski <linux@xxxxxxxxxxxxxxxxxxxx>,	linux-kernel@xxxxxxxxxxxxxxx,	linux-alpha@xxxxxxxxxxxxxxx,	linux-arm-kernel@xxxxxxxxxxxxxxxxxxx,	linux-mips@xxxxxxxxxxxxxxx,	linuxppc-dev@xxxxxxxxxxxxxxxx,	linux-sh@xxxxxxxxxxxxxxx,	sparclinux@xxxxxxxxxxxxxxx,	linux-pci@xxxxxxxxxxxxxxx,	xen-devel@xxxxxxxxxxxxxxxxxxxx,	linux-acpi@xxxxxxxxxxxxxxx
 
- From: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
 
- Date: Thu, 30 Mar 2023 19:24:33 +0300
 
- Cc: Miguel Ojeda <ojeda@xxxxxxxxxx>,	Richard Henderson <richard.henderson@xxxxxxxxxx>,	Ivan Kokshaysky <ink@xxxxxxxxxxxxxxxxxxxx>,	Matt Turner <mattst88@xxxxxxxxx>,	Russell King <linux@xxxxxxxxxxxxxxx>,	Andrew Lunn <andrew@xxxxxxx>,	Sebastian Hesselbarth <sebastian.hesselbarth@xxxxxxxxx>,	Gregory Clement <gregory.clement@xxxxxxxxxxx>,	Thomas Bogendoerfer <tsbogend@xxxxxxxxxxxxxxxx>,	Nicholas Piggin <npiggin@xxxxxxxxx>,	Christophe Leroy <christophe.leroy@xxxxxxxxxx>,	Anatolij Gustschin <agust@xxxxxxx>,	Yoshinori Sato <ysato@xxxxxxxxxxxxxxxxxxxx>,	Rich Felker <dalias@xxxxxxxx>,	John Paul Adrian Glaubitz <glaubitz@xxxxxxxxxxxxxxxxxxx>,	"David S. Miller" <davem@xxxxxxxxxxxxx>,	Bjorn Helgaas <bhelgaas@xxxxxxxxxx>,	Stefano Stabellini <sstabellini@xxxxxxxxxx>,	Oleksandr Tyshchenko <oleksandr_tyshchenko@xxxxxxxx>
 
- Delivery-date: Thu, 30 Mar 2023 16:28:47 +0000
 
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
 
 
 
The pci_bus_for_each_resource() can hide the iterator loop since
it may be not used otherwise. With this, we may drop that iterator
variable definition.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
Reviewed-by: Krzysztof Wilczyński <kw@xxxxxxxxx>
Reviewed-by: Philippe Mathieu-Daudé <philmd@xxxxxxxxxx>
---
 drivers/eisa/pci_eisa.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/eisa/pci_eisa.c b/drivers/eisa/pci_eisa.c
index 930c2332c3c4..8173e60bb808 100644
--- a/drivers/eisa/pci_eisa.c
+++ b/drivers/eisa/pci_eisa.c
@@ -20,8 +20,8 @@ static struct eisa_root_device pci_eisa_root;
 
 static int __init pci_eisa_init(struct pci_dev *pdev)
 {
-       int rc, i;
        struct resource *res, *bus_res = NULL;
+       int rc;
 
        if ((rc = pci_enable_device (pdev))) {
                dev_err(&pdev->dev, "Could not enable device\n");
@@ -38,7 +38,7 @@ static int __init pci_eisa_init(struct pci_dev *pdev)
         * eisa_root_register() can only deal with a single io port resource,
        *  so we use the first valid io port resource.
         */
-       pci_bus_for_each_resource(pdev->bus, res, i)
+       pci_bus_for_each_resource(pdev->bus, res)
                if (res && (res->flags & IORESOURCE_IO)) {
                        bus_res = res;
                        break;
-- 
2.40.0.1.gaa8946217a0b
 
    
     |