Re: [PATCH] xen/cpufreq: Remove <asm/bug.h>

[Oleksii <oleksii.kurochko@xxxxxxxxx>]

On Tue, 2023-03-14 at 08:14 -0400, Jason Andryuk wrote:
> On Tue, Mar 14, 2023 at 6:19 AM Jan Beulich <jbeulich@xxxxxxxx>
> wrote:
> > 
> > On 13.03.2023 18:51, Jason Andryuk wrote:
> > > The header is unneeded - there are no uses of BUG() or WARN() in
> > > these
> > > cpufreq files.  Remove the include.  It is still include
> > > transitively
> > > from xen/lib.h.
> > > 
> > > Signed-off-by: Jason Andryuk <jandryuk@xxxxxxxxx>
> > 
> > This, in a way, is a review comment on Oleksii's "xen: change
> > <asm/bug.h>
> > to <xen/bug.h>". We can certainly put in the change as you have it
> > (for
> > him to drop the touching of the two files), but I'd find it more
> > logical
> > to continue to be part of his change, just with the xen/bug.h
> > replacement
> > includes dropped. Thoughts, either of you?
> 
> Yes, Oleskii's work brought it to my attention.  I submitted it this
> way to follow the "one change per commit" rule of thumb, seeing it as
> distinct from, though related to, the asm -> xen rename.  If you
> prefer to have it rolled into Oleksii's change, that is fine by me.
I think we can do it as a part of my changes to not produce additional
commits with the similar meaning.
> 
> > Things would be different if it was clear that the change here was
> > dropping
> > all unnecessary includes from the cpufreq files. But that doesn't
> > look to
> > be the case, as I think ...
> 
> Correct, I did not inspect other includes.
> 
> Regards,
> Jason
~ Oleksii