Re: [OSSTEST PATCH] PDU/IPMI: Be less aggressive with IPMI commands

[Ian Jackson <ijackson@xxxxxxxxxxxxxxxxxxxxxx>]

Anthony PERARD writes ("[OSSTEST PATCH] PDU/IPMI: Be less aggressive with IPMI 
commands"):
> The machine rimava0 doesn't power off or power on when we keep doing
> "power status" then "power off" ipmi command without waiting.
> 
> Currently, osstest does:
>     loop
>       ipmitool power status
>       ipmitool power off
>       sleep 1
> 
> This loop goes on forever, the machine never change power state.
> Adding some wait in between both command works.

How sad.

> While here, test for timeout just after a status check instead of
> sending the `power off` command again which we would never check the
> result of.

Reviewed-by: Ian Jackson <ijackson@xxxxxxxxxxxxxxxxxxxxxx>

-- 
Ian Jackson <ijackson@xxxxxxxxxxxxxxxxxxxxxx>   These opinions are my own.  

Pronouns: they/he.  If I emailed you from @fyvzl.net or @evade.org.uk,
that is a private address which bypasses my fierce spamfilter.