Re: [PATCH v3 3/4] xen/arm: switch ARM to use generic implementation of bug.h

[Oleksii <oleksii.kurochko@xxxxxxxxx>]

Hi Julien,

On Sat, 2023-02-25 at 16:49 +0000, Julien Grall wrote:
> Hi Oleksii,
> 
> On 24/02/2023 11:31, Oleksii Kurochko wrote:
> > The following changes were made:
> > * make GENERIC_BUG_FRAME mandatory for ARM
> 
> I have asked in patch #1 but will ask it again because I think this 
> should be recorded in the commit message. Can you outline why it is
> not 
> possible to completely switch to the generic version?
I haven't tried to switch ARM too because of comment regarding 'i' in
<asm/bug.h>:
/*
 * GCC will not allow to use "i"  when PIE is enabled (Xen doesn't set
the
 * flag but instead rely on the default value from the compiler). So
the
 * easiest way to implement run_in_exception_handler() is to pass the
to
 * be called function in a fixed register.
 */
#define  run_in_exception_handler(fn) do {                            
\

So I decided to leave ARM implementation  as is.
But I'll try to switch it for the test and look at tests. If tests
won't fail that I'll switch ARM to generic implementation too.

> 
> Cheers,
> 
~ Oleksii