[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 2/4] xen: change <asm/bug.h> to <xen/bug.h>
- To: Oleksii <oleksii.kurochko@xxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Tue, 28 Feb 2023 14:30:17 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=akQIpc+pcGoR44L4zVN4vbvumJooUlhCV2CPJgRI9B4=; b=AzdkrvUt92uSctgQfpoB5nurH9WwMS2dRTcZVT+K7OkSSwiao6z/YilDTuHJPgvBYdmpTNgWXiHUaxm3tlEeRVfCsQREBnZvCoHNWfrXoFGq70j3JzZ4i8B+IOmT3dZbsaoMD4BmehZWTsnFjn4WpYrC2yfwebBafPLW8KWJKlIYEu2j4+T2D98rAtvhFeCYod/fc/SmGCHdpQOmmM9JkanryJMjXykh3xLob3yAI9rIAagrp2NtkSXQd1yMBRHcMUEAcM412Y+qk9rbFp3Kp1Eu35Y3przUJ+61tpa1llEkyqOoZasc14ii5MKVfzKV4/u+WxEobh0FN0STW6Q3qw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bQN+DZuZ+MSAClP4sUpFG6AoRHrKKaVkqTaKQrtQWwQI/9uvkPq9Z8vOy5aIspBD/k7m+JAfGNnldwEKCGR8HqjX9GVVpRn+YcL4LjXI0q419PlWIFvFysu4ctehYUtx7bV12/OpDxUzv7veYd2hyCAu6b/Aj9PLHvwQw1wDCUJX+9Ij0d0C8y+9KcSz/ImNI6bYwzqvTSjjIrY9Q3yni3vz4JJ5N9iKznoX4hDoDFT12fXiVzU7VNsnJ+FMAqkMDtY7x0mAGlKBQ5FM/TP5pyv2tJZ375yG96tUfa4EZrfYrpiJKx82PIxAsSmxMCX9mWuZ2KIesYvN0jILfCrXnA==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Gianluca Guida <gianluca@xxxxxxxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Tue, 28 Feb 2023 13:31:10 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 28.02.2023 14:07, Oleksii wrote:
> On Sat, 2023-02-25 at 16:47 +0000, Julien Grall wrote:
>> On 24/02/2023 11:31, Oleksii Kurochko wrote:
>>> --- a/xen/arch/arm/include/asm/bug.h
>>> +++ b/xen/arch/arm/include/asm/bug.h
>>> @@ -1,6 +1,8 @@
>>> #ifndef __ARM_BUG_H__
>>> #define __ARM_BUG_H__
>>>
>>> +#include <xen/types.h>
>>
>> You are not adding new code in bug.h, so can you explain why this is
>> now
>> necessary?
> I am not adding new code but inside 'struct bug_frame' there are
> uint16_t and uint32_t which are defined in <xen/types.h>.
>
> And after <asm/bug.h> was changed to <xen/bug.h> it started to complain
> on these types.
Wouldn't xen/bug.h want to include xen/types.h anyway, and then clearly
before including asm/bug.h?
Jan
|
