[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 10/14] x86/vmx: move declarations used only by vmx code from vmx.h to private headers
- To: Xenia Ragiadakou <burzalodowa@xxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Mon, 27 Feb 2023 16:25:35 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=d5vXTwSreSMlnb91MRRfmR+e3Nq9kvvrXKqilsHyd0M=; b=SGmpm+6VyWddq5ANo/ZrZh0UxUYuPVqECn6l9stmWFGlMFmNPWX/QLLv2OpLO5l3OBuStbG4cwK3x0H64Pze6BEFi5JWfZzWHcmGG7PdUfatPVHj/cM/fLnzOuEjL4wuiimxvaHuvJZYjcyDhp6SuEKafxmiXP8Cs0pTuBNwNJf6N6eHoF6VOnBLq70XhMZbc/dyj/PnLdzPJBLJ2cumV/1af2HbxDI1e8lzZU/KLGZR6ECPyNH9OxIJ6wAMeOVb6IwvXfFZ3Fa4+Ci0mJZ3u6w5reRjC747OFRjrr3lZfv2+LkBMOQPUv+POR8wXcsKNjGG0gEa/tpjJjWJra2Ltg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Y9ScSJwsNlZRLG5jbjlPR3I0KF4o73pclXpyVwBekoSqNgC+8CmN9CYYRWqyAGIdTd6EpH6Ntld9+SeleMeCuW3T3SILWx8bBytrCNnjygSylkQcv1Yh+eHevQEY/uqXujIPzX2P/m7MAyHp3p9pZ7KGrqgd1NjqZIBrxVoBrF8ObmwGbqwjhkDyx0NXRQfWY2dwWIjfDn41lBZz9Pt5DucLHBPijeRQNDE43DwThNmsKJmX2uSsRKStDUL6L5dCQ6V093bM+KvLOyAbQlv6HeghuJI0N5vwPdEGcFQWJsgBIFD6h3uTKkgsd3AzhuPhCV+hPhwT6+cFG1e7caDRLw==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Jun Nakajima <jun.nakajima@xxxxxxxxx>, Kevin Tian <kevin.tian@xxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Mon, 27 Feb 2023 15:25:49 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 24.02.2023 19:50, Xenia Ragiadakou wrote:
> --- /dev/null
> +++ b/xen/arch/x86/hvm/vmx/pi.h
> @@ -0,0 +1,78 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
> +/*
> + * pi.h: VMX Posted Interrupts
> + *
> + * Copyright (c) 2004, Intel Corporation.
> + */
> +
> +#ifndef __X86_HVM_VMX_PI_PRIV_H__
> +#define __X86_HVM_VMX_PI_PRIV_H__
I can see that you need something to disambiguate the two vmx.h. But
here you don't need the PRIV infix, do you? Even in the private vmx.h
I'd like to ask to consider e.g. __VMX_H__ as the guard (and then
__PI_H__ here), rather than one which doesn't really match the
filename.
Jan
|
