[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v1 2/3] xen/riscv: setup initial pagetables
- To: Julien Grall <julien@xxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Mon, 27 Feb 2023 16:17:54 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=59Fgne/iInyIhaI5N3irYGC1XaNEqmK7l8NM5DvEm3E=; b=VTNEvFI7YJCWKTHJn7uZ1VgGsTUEDUrPYMZXw50KZPRAQiiZvYMrJx1UMcCySVGYBmWbiACRT1RYA6FdukZoV7vBWsPgkRThTREbez1L37QEpeNdbxJIA+hBlRxid7FsEp6aIZCFg2eqvRruPMgHvseSmKcadhiWd1vGhKzc3Be1ZP2FnVESAN5AsOgmjWHTr44onbUp2ZL/xThIdKFcwHZCs1Hjcs4ih67t5X7mF+a/QszK5axeTM0TfIiUEm/iHOxeW8r7kNGjKvvAWoZ7jZKCtnJ8zEPvs2VtJAlyZHMCJe0u7iMR90iA8dAbeQznu0ER9YwRGPbWZMN3vJBe0g==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bmK5I2NYSBs8OrQU33MZT0AArXPRagj2VmdMsMEVgL5r42UeFYAStIJ3UOU22/YOi2AIr8Q6D/z1NGQ/naSfT3BMwGkdtMA93p9l+JnS98bNiAOG8dVReAW3j2IHKZQlUH3t43ZATCB1fPNIv7PyUKWzCdCfmMQVBxCCAnYpVMFQtkHXpXt5yhdiz6tHk3NW+GcpzFUJ3dom/0IMfX6ZFrtiFbneBJiw1ntQY6ZrMEl/O9+3C6yl9d/58JGWuVMpCzUXEMSl7JoOvkryeYxCUaEX7NorLcdWNhaHS3RIKE+O38ELVFu4vIp0wv/khLRlX7ztMcuXFQdCLTKmmKJCuw==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Gianluca Guida <gianluca@xxxxxxxxxxxx>, Bob Eshleman <bobbyeshleman@xxxxxxxxx>, Alistair Francis <alistair.francis@xxxxxxx>, Connor Davis <connojdavis@xxxxxxxxx>, Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Mon, 27 Feb 2023 15:18:16 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 25.02.2023 19:05, Julien Grall wrote:
> On 24/02/2023 15:06, Oleksii Kurochko wrote:
>> @@ -43,6 +45,11 @@ static void __init disable_fpu(void)
>>
>> void __init noreturn start_xen(void)
>> {
>> + unsigned long load_start = (unsigned long)start;
>> + unsigned long load_end = load_start + (unsigned long)(_end -
>> _start);
>
> I am a bit puzzled, on top of load_addr() and linker_addr(), you wrote
> it can't use global variable/function. But here... you are using them.
> So how is this different?
I guess "use" means "access" (i.e. call a function or read/write a
variable). I suppose it does not mean "take the address of".
Jan
|
