[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 2/4] xen: change <asm/bug.h> to <xen/bug.h>
- To: Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Mon, 27 Feb 2023 15:29:55 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/8Zed6N2stI86YmYnkXPep1D1Ny6NPk7wNNmHzXRReg=; b=B97/0j3Li3+gclWQBCe0A9GGSZ3FBQ8osgdb7OdsNurYutrhGsnGyixE/Kv7BZ0PB3AD+0XBnhSreAVDZzEFi3T4REL3Jb2L6TDd+tvw2gI0EYhP4D3izjB+z1XkcANEt2s71DvdlnzGDetvyu6VDMj1vuYrxgdCPwh7fuISHdkUovBo61RpXsLciFHk/2VpGIdHB9XeJQMh6H5hu+7TuJpHW3yBGlHOcuogncNz6nwkbD3EgfNjjDImMFH9RvVqzn/h5cNKa0O9yP7eLS+vr3xbFE03nSUAqL8KKujNY7QEuoBtrQpl61SzClatLjBkTcqy1LZXPOFXVf7XPfPzRA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=my9L38EIr5XyOfzwAweXEdhCwUty8EwZLHVCflCT/Mmiz5VE3xtMCCCkVJY7avmPpHMpY5bphVeABlG1EHvn52ibTQcqzxeI42dXxVXI5nFQkfM/BQYdNNNLgEqIz8IWkTPEpFcM3mi1FGTkLDEC8YA21BQ2X+XoR73700yRVMlpPLlPh8n5zc9PSMusA/t7oapmz+Mmkn/v8UH3+sg+NjB0T5eAvCFxxwQXzsTzL5pqhXH5/rEsfhb/Hl95wC3QJk+S0aJ5QffFmT/olwmPZ3G5nSPtEaWIYzm67yvSk27bZ/w/rzwyK8pQc9TnRu7TndppBg8Ezw70ZvkmQqIZoA==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Gianluca Guida <gianluca@xxxxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Mon, 27 Feb 2023 14:30:42 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 24.02.2023 12:31, Oleksii Kurochko wrote:
> Since the generic version of bug.h stuff was introduced use <xen/bug.h>
> instead of unnecessary <asm/bug.h>
You keep saying "unnecessary" here, but that's not really correct.
Including asm/bug.h alone simply becomes meaningless. So how about
"... instead of now useless (in isolation) <asm/bug.h>"?
> --- a/xen/arch/x86/include/asm/bug.h
> +++ b/xen/arch/x86/include/asm/bug.h
> @@ -1,19 +1,10 @@
> #ifndef __X86_BUG_H__
> #define __X86_BUG_H__
>
> -#define BUG_DISP_WIDTH 24
> -#define BUG_LINE_LO_WIDTH (31 - BUG_DISP_WIDTH)
> -#define BUG_LINE_HI_WIDTH (31 - BUG_DISP_WIDTH)
> -
> -#define BUGFRAME_run_fn 0
> -#define BUGFRAME_warn 1
> -#define BUGFRAME_bug 2
> -#define BUGFRAME_assert 3
> -
> -#define BUGFRAME_NR 4
> -
> #ifndef __ASSEMBLY__
>
> +#define BUG_FRAME_STRUCT
> +
> struct bug_frame {
> signed int loc_disp:BUG_DISP_WIDTH;
> unsigned int line_hi:BUG_LINE_HI_WIDTH;
Why would x86 continue to define its own bug_frame (and other items)?
Jan
|
