[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 3/3] tools: add offsetof() to xen-tools/libs.h
- To: Juergen Gross <jgross@xxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Mon, 27 Feb 2023 13:31:11 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=HV7PqWQSzHcfNqI/zrUSn1mT7H2bAdoGk7sR4Shd2oA=; b=R7p5YXnCP4Vg22ZkRhqbqgu7f2Tx+1Vr+SeF717x+kfloLF0/Cclk4O1zS32P1rhASyoPHm54r2ts8j5Ur3RaUr2c1uBHtG5odOsCIOs1/eBwg44xxjuAx5sjaAm2W/ATb50u3zs7CDqklyEwY4wxPmU1TBTUzntdq38x0o4JPZAxB6uuLXCJ8yYBnww2nI0tGfT2hj0YTb1MeM0g4CJWunYraV8P7g5oq4lLQOBcXvbVEXQcRMChIu5mm1fYMXgp+rVndv5xbGgCnVAkXPA2fj62PVgwtw48F6DJa9iw72qr4qL18rog9LeRvFO2HRC2/VHXahGhYRWs41cziXN7A==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=a1qlpLZ8rEyz9DB8byEOguHhF7THqyGQw2PK5OJLNqAbWcsiAWlc5TF4e+AHaiI+mXezD/MWZD/Ppynlo/Es4BldacBsrvKJQLp1XFbw6aLCZFdYdpG16o5cX/1B2x8oCqnkveno9lk5T17FRfMNjD7S/FO1cfbWmrEFq79nJHj4O7hZLMyuzim77LS/DNzwjbt5m38Hj0DOn40a/U6M/EUrYE+/dugmqksB39mZ6pVCAIdFAdf8PmodHiX1owSgaxxszOwDbPNwXhZqRKdykvgpdwcDVtsO9yWCwxQvHF5wqjxZ8SE4zzo+5yd/oHaprdv594yk00U/o8UhFecDXA==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Mon, 27 Feb 2023 12:31:31 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 27.02.2023 13:09, Juergen Gross wrote:
> --- a/tools/firmware/hvmloader/util.h
> +++ b/tools/firmware/hvmloader/util.h
> @@ -30,9 +30,6 @@ enum {
> #define SEL_DATA32 0x0020
> #define SEL_CODE64 0x0028
>
> -#undef offsetof
> -#define offsetof(t, m) ((unsigned long)&((t *)0)->m)
> -
> #undef NULL
> #define NULL ((void*)0)
>
> diff --git a/tools/firmware/include/stddef.h b/tools/firmware/include/stddef.h
> index c7f974608a..926ae12fa5 100644
> --- a/tools/firmware/include/stddef.h
> +++ b/tools/firmware/include/stddef.h
> @@ -1,10 +1,10 @@
> #ifndef _STDDEF_H_
> #define _STDDEF_H_
>
> +#include <xen-tools/libs.h>
I'm not convinced firmware/ files can validly include this header.
Jan
|
