[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 05.5/14] x86/svm: Decouple types in struct nestedsvm
- To: Xenia Ragiadakou <burzalodowa@xxxxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Date: Mon, 27 Feb 2023 10:47:37 +0000
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YsQyEKRRbfhV8Oz0ceHjsFMUvyKbHIOA4B/3kRCs+Oc=; b=P6NDDuYdhPY61gvbTXP/XzIAbGzQiKI5wPtC7BFd6242HQbQx77rxLpLro6aeODKFgMssOAuZLIoM0G2+5CMr9T5zrcc5+n8dBh4AtT7px7/nP5ovuFaw0BTOocV5N1/Soe3t7BUQIlfQHRUINTAfwz4+SPjN7hOUnEP35mQGPU0IZjiJQqZdotNxfvEdaNasoKArY9+xW226mdXzpok0nN2GBXGfL59Qb0yDgXjAxoL0bM7xeVOViMZEIGB4ZJfgNzmrGoZNHF72VZGtBIbU+f1zYO32VieYTFMfHmWOxCVJWgOpKOUAXDtdHndg9iMdhFJz3GZVgK1BSL8DRw0hg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CeowLBv7zGmH7eLS9yk75lJOLwSHox5WmTpuIE855qIjUPn6dw93jZU5crjf1/XkBftc5uSa0vBnnQLyNmEEie/YsbS1f9VXFfa+nx/uTAypzrDRnxguT0ROSQ0rn3CdtulKjH8UvU2gE4RmJBhaHoHcEKd7Eefwx05LP03q49hmVTMqSdrtVPFS6w7BuUcti9wYtYB9p4rdoqSL71n8oOadZ+5Bbb7ojY8YktleCIt8kr5y7Hc5Iw7Gh4qmXNTnAGArs3MXofdrkHb/+hVdEtho1rLmHrjHh6VaZoZ3usigBNIYYB5CvywVThaQbnC/GNrJz5usYqq0m4JUJacMNw==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Jan Beulich <JBeulich@xxxxxxxx>
- Delivery-date: Mon, 27 Feb 2023 10:47:51 +0000
- Ironport-data: A9a23:Cs10X6qZxpuOgnXjtniXVpgyd7deBmIsZBIvgKrLsJaIsI4StFCzt garIBmEM/3YYDDxLdEgYN6+/UtQv5WByIdmSAM+q3o3HytE95uZCYyVIHmrMnLJJKUvbq7FA +Y2MYCccZ9uHhcwgj/3b9ANeFEljfngqoLUUbKCYWYpA1c/Ek/NsDo788YhmIlknNOlNA2Ev NL2sqX3NUSsnjV5KQr40YrawP9UlKm06WxwUmAWP6gR5weEzSZNVfrzGInqR5fGatgMdgKFb 76rIIGRpgvx4xorA9W5pbf3GmVirmn6ZFXmZtJ+AsBOszAazsAA+v9T2Mk0MC+7vw6hjdFpo OihgLTrIesf0g8gr8xGO/VQO3kW0aSrY9YrK1Dn2SCY5xWun3cBX5yCpaz5VGEV0r8fPI1Ay RAXAHcndiud2OGu+pWYb8xjp/h/IdH0N5xK7xmMzRmBZRonabbqZv2WoPV+jHI3jM0IGuvCb c0EbzYpdA7HfxBEJlYQDtQ5gfusgX78NTZfrTp5p4JuuzSVkFM3j+SrbIG9lt+iHK25mm6xo G7c8nu/KRYdLNGFkhKO8262h/+JliT+MG4XPOzoqKA02wPJroAVIBo1Z2GL/MiHsV6VRIJme 04wx20oiLdnoSRHSfG4BXVUukWstAMGSdNUFOE99wilxa/d4gLfDW8BJhZRZdpjuMIoSDgC0 l6Sg8ivFTFpqKeSS3+W6vGTtzzaEQo/IHIGZCQEZRAY+NSlq4Y25i8jVf5mGa+xy9fzSTf5x mjWqDBk3+lIy8kWy6+84FbLxSq2oYTERRI04QORWX+56gR+Z8iuYInABUXn0Mus5b2xFjGp1 EXoUeDHhAzSJflhTBCwfdg=
- Ironport-hdrordr: A9a23:ownjWa6XUtg9BPKNdAPXwMrXdLJyesId70hD6qkXc20yTiX4rb HIoB1/73TJYVkqKRMdcLy7V5VoIkmslqKdg7NxAV7KZmCP0geVxepZjbcKrQePJ8VSndQx6U /mGJIObOEZ2TNB/KPH3DU=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 27/02/2023 8:52 am, Xenia Ragiadakou wrote:
>
> On 2/24/23 23:06, Andrew Cooper wrote:
>> struct nestedvm uses mostly plain integer types, except for
>> virt_ext_t which
>> is a union wrapping two bitfield names. But the nested virt logic
>> only ever
>> deals with it as full opaque register.
>>
>> Switch it to being a plain uint64_t, allowing us to hide even more of
>> the SVM
>> internal infrastructure.
>>
>> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
>
> Reviewed-by: Xenia Ragiadakou <burzalodowa@xxxxxxxxx>
>
On second thoughts, the fact that this patch compiles means its a
write-only variable.
Lemme experiment quickly with an alternate patch.
~Andrew
|
