[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] build: add crypto/ to SUBDIRS
- To: Michal Orzel <michal.orzel@xxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Mon, 27 Feb 2023 11:10:06 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rya8ckti/z1muuzqQprH8wpyD6pFZgRxIBnQYYpvtvk=; b=FPyjaSSE+8pJ5nKELarDZKtpL281d9GuQ+6sIC6QjruqhOWLLUfTilUPd1/+j7EXTDn6f/8g6tndmh5JrxKd/8DWqVHyuzffHEX/vMB9afCy1myurK0BeYg48JINwy0a1zDYLgIrk5ZRKNDJxuHnn6SNvd0ce64IzeB+2t3ncCgOQPfQHPhm3emGEJPFcxZMOvuuzRg5RE8EMjNikc/oQDErgm6usHljwgOzuwT64GJIJV2Lp0lrNTsaufj21irCwMOkD65tJmDlSi8NsBrd7M/Y88A/dHzYPAfygO5vlAe2ngw12bcXBTDUirM7Q2YwxYUCXAEdzLjWnk/DcokGFg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aCBuojq9wpKDjs69h2BJPNokmRkX9GZCDI9XDlmRJMbKmo7vvl0OKPeiSxOcUJTNTY5zJX1YpcZNY7+jTyj284AqHo2Nab3d8H/3/WUs77P/G/o66Qdzl3z2dT4WgmAY4SScP0hTVj2p0a4u378grNWRMKAligVPp16uQ5Y4IK2uYVr5CJYV71JATf3aNBaMEdmPrZdwPNv3E1xJT70qFr2U0vot9hLOoS4/xQmnb5fFkkc9nuVdSuUADjwUD3uop7bA1cdb+SEm6Isz8ZHfsqDXVoJkP5fU1wmKJoL/yphiQGDlcVsJvwW4cgpUymRY7+FHX2wEVpYTtaPO5gK2CA==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Mon, 27 Feb 2023 10:10:13 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 27.02.2023 10:53, Michal Orzel wrote:
> --- a/xen/Makefile
> +++ b/xen/Makefile
> @@ -589,7 +589,7 @@ $(TARGET): outputmakefile FORCE
> $(Q)$(MAKE) $(build)=. arch/$(TARGET_ARCH)/include/asm/asm-offsets.h
> $(Q)$(MAKE) $(build)=. MKRELOC=$(MKRELOC) 'ALL_OBJS=$(ALL_OBJS-y)'
> 'ALL_LIBS=$(ALL_LIBS-y)' $@
>
> -SUBDIRS = xsm arch/$(TARGET_ARCH) common drivers lib test
> +SUBDIRS = xsm arch/$(TARGET_ARCH) common crypto drivers lib test
> define all_sources
> ( find include -type f -name '*.h' -print; \
> find $(SUBDIRS) -type f -name '*.[chS]' -print )
As long as it's arch/$(TARGET_ARCH) that's used here, crypto should imo
also only be included when selected (or at the very least only when an
arch might select it, which afaics is possible on x86 only right now).
It would also help if in the description you made explicit that SUBDIRS
isn't used for anything else (the name, after all, is pretty generic).
Which actually points at an issue: I suppose the variable would actually
better be used elsewhere as well, e.g. in the _clean: rule and perhaps
also in the setting of ALL_OBJS-y. (That'll require splitting the
variable, to that e.g. _clean would use $(SUBDIRS), $(SUBDIRS-y), and
$(SUBDIRS-) collectively.) It is, imo, that lack of consolidation which
has caused crypto to be missing from SUBDIRS.
Jan
|
