[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 04/14] x86/svm: make emulate.h private
- To: Xenia Ragiadakou <burzalodowa@xxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Date: Fri, 24 Feb 2023 19:50:45 +0000
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dEGrEgzvh+KXhdmODzmXHYdU1IPPQ3aQQ45GA7ydIjw=; b=gH+LtXQ1XHlQKEc/8MnLpYAYU2D0ds631BV+3rXK/U5GhCWtva6PndmuHwnuzW9tp+RY8qk+BTJEyarZtnrynBtZ96xfGLWbZM9YFMjWL/+jiM+L2GpF52QJRepWkQWpsTMChRKxRg43Pvi4Ws/ixBeGEeOUkKHZbh9sIwzISpGEu1qYyfEByACDHZHt/dnITpjnzIuZtZAMBZQZnelIKNPg4FyQY5Wb9N7hrj8lnvjyO5lj60X15nZWPUHbvZPRzv7nsvZc03k3+32fbFRNDDYn4DaRVxB54O1GS4Av3EhHk76wwczHM+wGp7N9xkVIrq9JQEYK3tH3uub4gY8vSw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oJ0tzZ+WE6l+RYZRvOmJdmk9tyYy7i8TH66sMaJ3ZMjidMXVbVTn/fso+4tx6r/dOXiewgI24TKYkkb2l+2ju80dqc2OZFDf1Od+Od+LGSw8rf1QgMk5Wix/NyZpKpwtZkR+ZsXM6Mykc4I+YfQTRM6kpmt1OkWbf8YB3rey7Rkpy8otSxHOAtD8pkyyC7+L9QHShiJBWsPCR4F7ljpnRIV7Y2ds0yIgQpJGSXIw3DNpRuSP+vzJ7mzjhiGMZSMcYqzkPETpNFFtInlhTYZD5Yloo3tNsHTpQwMu4ws5OYetGausFz5bQtUpJCoZO05ZVYnmtUTcz/jJqCScV5YX5A==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Jan Beulich <jbeulich@xxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
- Delivery-date: Fri, 24 Feb 2023 19:51:20 +0000
- Ironport-data: A9a23:HLVrCK+3zYrO2l+9XBtZDrUDu3+TJUtcMsCJ2f8bNWPcYEJGY0x3y mcbWGyOa/iPN2L0Ltl0OYm0oB4BvZDWyN8yTQNuqCE8E34SpcT7XtnIdU2Y0wF+jCHgZBk+s 5hBMImowOQcFCK0SsKFa+C5xZVE/fjUAOG6UKicYXoZqTZMEE8JkQhkl/MynrlmiN24BxLlk d7pqojUNUTNNwRcawr40Ire7kIw1BjOkGlA5AdmP6oX5AS2e0Q9V/rzG4ngdxMUfaEMdgKKb 76r5K20+Grf4yAsBruN+losWhRXKlJ6FVHmZkt+A8BOsDAbzsAB+v9T2M4nQVVWk120c+VZk 72hg3ASpTABZcUgkMxFO/VR/roX0aduoNcrKlDn2SCfItGvn9IBDJyCAWlvVbD09NqbDklx5 b84LSBccCuKivi3mYKxZsp0pP4seZyD0IM34hmMzBn/JNN/GdXvZvuP4tVVmjAtmspJAPDSI dIDbiZiZwjBZBsJPUoLDJU5n6GjgXyXnz9w8QrJ4/ZopTWDilUpj9ABM/KMEjCObexTklyVu STt+GPhDwtBHNee1SCE4jSngeqncSbTCd1CSOLhq6ICbFu7300IUjoMTHiCs6OhrXGbAPR/D UAW0397xUQ13AnxJjXnZDWyvWSWtxobV91PGsU17QiMzuzf5APxLngJSHtNZcIrsOcyRCc2z RmZktXxHzttvbaJD3WH+d+8rzm/JCwUJm8qfjIfQE0O5NyLiJ43pgLCSJBkCqHdszHuMTT5w jTPoC1ggbwW1JYPz//ipQ+BhC+wrJ/USAJz/h/QQm+u8gJ+YsiiepCs7l/Yq/1HKe51U2W8g ZTNoODGhMhmMH1HvHXlrDkldF1x28u4DQ==
- Ironport-hdrordr: A9a23:74Tslq4XeBoc0qcrmAPXwNnXdLJyesId70hD6qkRc3Fom6mj/K qTdZsgtSMc9wxhOk3I9eruBEDiex/hHPxOkOos1N6ZNWHbUQCTTb2Kg7GN/9ToIVyaytJg
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 24/02/2023 6:50 pm, Xenia Ragiadakou wrote:
> The header asm/hvm/svm/emulate.h is used only internally by the SVM code,
> so it can be changed into a private header.
>
> Take the opportunity to use an SPDX tag for the licence.
>
> No functional change intended.
>
> Signed-off-by: Xenia Ragiadakou <burzalodowa@xxxxxxxxx>
The name emulate.h is rather stale now. We used to have a full ad-hoc
x86 emulator in emulate.{h,c}, before the work to use one single
emulator (rather than the 4(?) we had at the time).
Nowadays, it's just the the instruction length helpers, which you can
see are wrappers around x86_insn_length() which is the main emulator.
Given that it's now just two function declarations and a few constants
for the instr_enc field, it would be better to just move them into the
private svm.h (like I did the asid declarations) and remove the header
entirely.
~Andrew
|
