[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] xen/riscv: init bss section


  • To: Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Fri, 24 Feb 2023 15:57:07 +0100
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4745qez8NjFm9C7vOU8UYAB/8/YMfohpH+6j+jrjx/k=; b=Krb1QJaRh4KgttMTKfyrPs9l8k1nzElG3oFb4TBd9iHTuAT5zZJoCrw7hFh5l1e+MwQvb56DGMDNuf9gHWc6VVwJF5ujR53a6I3bYyjGsGZzpp0pZo9fZdeytpCWdRh5/kXUh1gPyJGYGu2bKERrN0ID8xZDiMCiMY+5fO7fxznlt0DSKs2U+M15Y+KRprm+Jm+3srDbAOM8Fx1KN7DSR1ozrQfj/sA6dI8YAEPn26FrZzqIpvRjVDcysCqOwL1EjTKPakn9tVYMD7K6XtiuAojVxJ4Svw/s9er/MH5lu+77y8eiwmVIusgY5gQxOuHiseU5jFb/fKHDbmF/b6cwHw==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Oqjs/GDkU19ic+2AmhSJFVYeeNYazmuopk0jZmg2RZY/cwSGloP7S5Sx97bKplq3VWejDp3jwQHaTf5+TIqI0L3+g0j8e1EfTYwx0XpsNlIdZ2viBpNQm6Y0zmIji80FJWJpBj4foiU/8+Q9AYOBy2wj4M7tSSRjo/BwKBcy+VlHPQUyjrtBqE0xJLmjBdcSNwIz/J6AoCSn34lWoD2o31gFTBYEgB+WH7yAS2iv30ZOKSj+vm2Da3+hfLc1XVD/YMSdeC085+YEjNDJp8noGKe9tIOMmqIq85nI9I8MjrVozKVNkOHS4s6W/WfkisrwRqgjvtv2SVjN5C99VZzLuQ==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
  • Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Gianluca Guida <gianluca@xxxxxxxxxxxx>, Bob Eshleman <bobbyeshleman@xxxxxxxxx>, Alistair Francis <alistair.francis@xxxxxxx>, Connor Davis <connojdavis@xxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
  • Delivery-date: Fri, 24 Feb 2023 14:57:42 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 24.02.2023 15:56, Jan Beulich wrote:
> On 24.02.2023 15:48, Oleksii Kurochko wrote:
>> +    char *bss = &__bss_start;
>> +
>> +    while ( bss < &__bss_end ) {
>> +        *bss = 0;
>> +        bss++;
>> +    }
>> +}
> 
> If you're sure you can defer this until being in C code, why not use
> memset()?

Oh, otherwise: Nit (style) - brace placement.

Jan




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.