[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN PATCH v7 07/20] xen/arm: ffa: add defines for framework direct request/response messages
- To: Jens Wiklander <jens.wiklander@xxxxxxxxxx>
- From: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
- Date: Fri, 24 Feb 2023 09:38:59 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LtX+fRT9aF0cgsD/r6pLaSpb9wDi1/WXMmNDtc8YzdE=; b=SQ5N/P5MH0fRIsN5dcfT4LV1FmCi9tjeybkmBYDyhrVTf4FmPnkizd380Y8tRJD0PChPqoGzt+P4RmbbFFWQSrRnbQDM0Qs/HEvHhvsPNi2woN8kOr90JIyIL+b7Ylcfi5LMeymMWD2xriXoHRKrWNF9YvRj1ojgCfqd8l8SfL0QKGck1BJjQ/yc56bDrR9ID6TnU9DRITgGII5sIzXNXBx75Vjzx/PZbhVMOsZNFzms5eK2+SbmMUXHzKYm+6uFNmlhv3bB9Mg/eReKLXwVBgfZtHH0eUHj17KMAy2CBR48KlDuxquTxqDCjCcKq/M/zamShQP60g5E/9DFiCv6hQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HcDSW3DpldOItYrs76q8XZPutzYiV87rnHFPRDda3cv6oqtTo7TZRkBjTo8qSNNh9aSiWdGp+cyyE5Axbr/hRlIKOhCOpuS+6y4wKZgo8q6WR2sxhtuFQgS2diMYhr18yaDV28N+WRBx5a4o7y0e0UbGBS96bzbUNPFAL4glE0DXWfv4nbXRO+GI0iuxDI1VtZaedST9mub0+ROD/CO+ZHdz05Eb+zfmA9tGGvL/DAX36DI8j/82iH8FXdC+mRUqrDFyLTFAgEK8nR6ejySuceyVezGvYadnsJJR8lIPoWGwJeLQd7n2j72QjZCBL3n+6josyu2xUvGvtWl5YiH3NQ==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Marc Bonnici <Marc.Bonnici@xxxxxxx>, Achin Gupta <Achin.Gupta@xxxxxxx>, Volodymyr Babchuk <volodymyr_babchuk@xxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>
- Delivery-date: Fri, 24 Feb 2023 09:39:24 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHZRtMc9l4FLuQsA0eLhPi3rXVDQK7d2fAA
- Thread-topic: [XEN PATCH v7 07/20] xen/arm: ffa: add defines for framework direct request/response messages
Hi Jens,
> On 22 Feb 2023, at 16:33, Jens Wiklander <jens.wiklander@xxxxxxxxxx> wrote:
>
> Adds defines for framework direct request/response messages.
>
> Signed-off-by: Jens Wiklander <jens.wiklander@xxxxxxxxxx>
> ---
> xen/arch/arm/tee/ffa.c | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/xen/arch/arm/tee/ffa.c b/xen/arch/arm/tee/ffa.c
> index f4562ed2defc..d04bac9cc47f 100644
> --- a/xen/arch/arm/tee/ffa.c
> +++ b/xen/arch/arm/tee/ffa.c
> @@ -56,6 +56,15 @@
> #define FFA_MY_VERSION MAKE_FFA_VERSION(FFA_MY_VERSION_MAJOR, \
> FFA_MY_VERSION_MINOR)
>
> +/* Framework direct request/response */
In the previous patch you were more verbose in the comment which was nice.
I would suggest here to use the same "format":
Flags used for the MSG_SEND_DIRECT_REQ/RESP:
BIT(31): Framework or partition message
BIT(7-0): Message type for frameworks messages
> +#define FFA_MSG_FLAG_FRAMEWORK BIT(31, U)
> +#define FFA_MSG_TYPE_MASK 0xFFU;
Maybe more coherent to name this FFA_MSG_FLAG_TYPE_MASK ?
I am a bit unsure here because we could also keep it like that and just
add _TYPE to other definitions after.
What do you think ?
> +#define FFA_MSG_PSCI 0x0U
> +#define FFA_MSG_SEND_VM_CREATED 0x4U
> +#define FFA_MSG_RESP_VM_CREATED 0x5U
> +#define FFA_MSG_SEND_VM_DESTROYED 0x6U
> +#define FFA_MSG_RESP_VM_DESTROYED 0x7U
> +
> /*
> * Flags used for the FFA_PARTITION_INFO_GET return message:
> * BIT(0): Supports receipt of direct requests
> --
> 2.34.1
>
Cheers
Bertrand
|
