[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 6/9] x86/vmx: move declations used only by vmx code from vmx.h to private header
- To: Xenia Ragiadakou <burzalodowa@xxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Fri, 24 Feb 2023 09:26:06 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+gh2gpVz2UE9d5OfUzIzUtMYYVvshlXExR70wjICqxI=; b=hUoIccixWVp3Pn5M0rQBQ1AntvHahCx+CN7rEbtcXuyjgg6MuVfzIJKzZQzj7V32IlujD8FOlAhRDR/TFL5L06JOJ1+KaifRJAJl5B+ho/J7l9S9nKSwGtkvTEXba9qs+euXj5MeN3nBaSE0BoHeZWMYTQgSjgEkpB4NK9u9Zqxcyiep83qZ0QPVLRY+H7qFE1+YOP+JKA5hESjI6FW9v62/AbLODQ0d+Tn1iFxH3ABDEtjh4pa3g0/fiSIh64ENcx38OOPL7rsXYmM1AcTNw1K4kc5FPL3JzbhttWxt3D4DR3LlYU4/Yl7J82t+92AkqiD6/wPsGOP5aA+acwztdw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=X75NqRkQCOoV/8mtx99tT783WkOinHZe2j8s1ju6E8hrPvIoOKXJdKttV5e6QgGNIkhWJ8K3AHR668wSr+LjamJhP1IrXsgBRYy0TD10pNVhrGFL2+afPRNPgAQ/K5P5tOyt2hoDoWoktdqpOlOfbzFggwq+x5yv/dccO65UJChyq0rQ4eev7W7HDh4/MH+dn1PhhfKb+OZsdCb8KXtcjNGiRhWC3Yrkb7VtGzr2DR8ZBcHHpNQWnWGV9kgaaxDespd03ny52uN2yjIVouAJvpKIhgB3ODTtlyWfGJhMkc8z/CJrYJRIMrtjraiCBQhoVJiHNueqc/RXdAmwQTrO9w==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Jun Nakajima <jun.nakajima@xxxxxxxxx>, Kevin Tian <kevin.tian@xxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Delivery-date: Fri, 24 Feb 2023 08:26:43 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 24.02.2023 08:49, Xenia Ragiadakou wrote:
> On 2/23/23 12:47, Jan Beulich wrote:
>> One file wide remark: I assume you've put things here in the order they
>> were in originally. I think it would be nice if some re-arrangement was
>> done, e.g. all structures first (unless there's a reason speaking
>> against doing so, and of course not including any which are local to
>> specific inline functions), then all variable decalarations, all function
>> delarations, and finally all inline functions.
>
> Yes I put everything as it was. Thanks for the review I will address all
> your comments above in v3.
>
> I have a question regarding the rearrangement, where are the definitions
> placed (if there is not a semantic relation with some other part)?
If there really are any which aren't associated with other items (struct
fields first of all), then I'd say near the top. But I'm less concerned
there; putting struct-s ahead of function decls is mainly because the
latter may use (some of) the former. Similarly var decls before or after
func ones is pretty benign (sometimes it may even be more logical to
intermix them to keep related things together).
One other general request: Please trim replies. I had to scroll through
the entire 500-line mail just to find a single remark at the end, which
clearly didn't require all the context to be kept.
Jan
|
