[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN PATCH v7 03/20] tools: add Arm FF-A mediator
- To: Jens Wiklander <jens.wiklander@xxxxxxxxxx>
- From: Anthony PERARD <anthony.perard@xxxxxxxxxx>
- Date: Thu, 23 Feb 2023 16:49:52 +0000
- Authentication-results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
- Cc: <xen-devel@xxxxxxxxxxxxxxxxxxxx>, <Bertrand.Marquis@xxxxxxx>, Marc Bonnici <marc.bonnici@xxxxxxx>, Achin Gupta <achin.gupta@xxxxxxx>, Wei Liu <wl@xxxxxxx>, Juergen Gross <jgross@xxxxxxxx>
- Delivery-date: Thu, 23 Feb 2023 16:50:26 +0000
- Ironport-data: A9a23:EfBTrq79S1uLZ94RqXU4IAxRtLnHchMFZxGqfqrLsTDasY5as4F+v moWW2uFa6mCYDegfIsnPo7i8xgAusTUx4UxTVFt+SE1Hi5G8cbLO4+Ufxz6V8+wwm8vb2o8t plDNYOQRCwQZiWBzvt4GuG59RGQ7YnRGvynTraCYnsrLeNdYH9JoQp5nOIkiZJfj9G8Agec0 fv/uMSaM1K+s9JOGjt8B5mr9VU+45wehBtC5gZlPaoR5weF/5UoJMl3yZ+ZfiOQrrZ8RoZWd 86bpJml82XQ+QsaC9/Nut4XpWVTH9Y+lSDX4pZnc/DKbipq/0Te4Y5iXBYoUm9Fii3hojxE4 I4lWapc6+seFvakdOw1C3G0GszlVEFM0OevzXOX6aR/w6BaGpdFLjoH4EweZOUlFuhL7W5m5 OMWOG0zRC24m//v/o2Ga/NAwf8NFZy+VG8fkikIITDxCP8nRdbIQrnQ5M8e1zA17ixMNa+AP YxDM2MpNUmeJUQVYT/7C7pn9AusrnD5bz1frkPTvact6nLf5AdwzKLsIJzefdniqcB9xx7A+ DKfozqhav0cHNeZxBGj/iuwut7wrADqUq9KHoGk5OE/1TV/wURMUUZLBDNXu8KRiEO4QJRAK k8Q8ywioLIa8E2tR8P6GRqirxasrhMaHtZdDeA+wAWM0bbPpRaUAHAeSTxMY8Bgs9U5LRQA2 0WVhdrvCXpKuaeMVHOG3r6OqHW5Pi19BWoLfyRCRwwD5djooak6lBeJRdFmeIa8hd30H3f/3 iiWpQA3nbBVhskOv42k+XjXjjTqoYLGJiY36R/QRXmN9R5iaciuYInAwVHD4OxJNoqxUliLt 39CkM+bhN3iFrnUynbLGr9UWuj0ubDcama0bUNT84cJ5iuj6yOdV71r/CwnGnhUE9woPgTHW RqG0e9O36N7MHyvZK5xRou+DcU20KTtfejYuuDogslmOcYoKlLelM16TQvJhj22zhBw+U0qE c3DGftAG0r2HkiOINCeY+4GmYEmySklrY84bcCqlk/3uVZyiZP8dFvkDLdsRrplhE9niF+Pm zq6Cydt40Q3bQEGSnOLmbP/1HhTRZTBObj4qtZMasmIKRd8FWcqBpf5mO1+JNQ0x/UMzriXo hlRv3O0L3Kl2BX6xfiiMCg/ONsDo74ixZ7EAcDcFQnxgCVyCWpexKwea4E2bdEaGB9LlJZJo w0+U5zYWJxnE22XkwnxmLGh9OSOgjz331PRV8dkCRBjF6Ndq/vhpoW9I1KyqnhTVkJad6IW+ tWd6+8SerJbLywKMSocQKjHI4+Z1ZTFpN9PYg==
- Ironport-hdrordr: A9a23:8arn+6H5+oLCUyENpLqEOseALOsnbusQ8zAXPiFKOGRom6mj/P xG885rsyMc5AxhP03I5+ruBEDwewK5yXcd2+B4UYtKNzOWwVdAQrsSkbcL3VDbehEX54Nmu5 uJkMJFeafN5SQRt7eG3OHxe+xL/DHMmJrEuQ9OpE0McenqAJsQjDuQY2ygYy9LrOkvP+tdKH KYi/A33AadRQ==
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Wed, Feb 22, 2023 at 04:33:00PM +0100, Jens Wiklander wrote:
> diff --git a/tools/libs/light/libxl_types.idl
> b/tools/libs/light/libxl_types.idl
> index 0cfad8508dbd..64fb570bc19a 100644
> --- a/tools/libs/light/libxl_types.idl
> +++ b/tools/libs/light/libxl_types.idl
> @@ -494,7 +494,8 @@ libxl_gic_version = Enumeration("gic_version", [
>
> libxl_tee_type = Enumeration("tee_type", [
> (0, "none"),
> - (1, "optee")
> + (1, "optee"),
> + (2, "ffa")
Could you add a comma at the end of this line? This will avoid the need
to change two lines the next time we are adding a tee_type (like you
have to do now).
Also, as you are changing libxl's API, could you add a LIBXL_HAVE_*
macro in libxl.h? Something like:
/*
* arch_arm.tee field in libxl_domain_build_info has ffa value.
*/
#define LIBXL_HAVE_BUILDINFO_ARCH_ARM_TEE_FFA 1
Thanks,
--
Anthony PERARD
|
