[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 2/4] xen: change <asm/bug.h> to <xen/bug.h>
- To: Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Thu, 23 Feb 2023 14:34:39 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=VDBEww+vtmrqli7kvOKODqkWWhCUTlM6b6MUXjIficI=; b=G3AQetg3wX1AANPEi7BoS6ufz0yLayHM06E9+kOztmVgpCTaXr2BjVALwJpzfV3yVk7jlBwfUPJBGLZ0Fnjx4Unz17dvjpqwxfLofaGCRM5NErP92dKt7DcW0et/XRA8TUZvimPgm3Y1Jpzxl0eFUx4rKGlvrT5Hs6oJHNIiQwCw8MPUnwPVQmTZr2uHsWiqBOgeawaIV4DuZgWQY+LFIY+Bhe8wErlBIFnY82MLxEskXMxeQng+hycTAk1h6b+0NpwJm9mtOszCaSRZQsZmRLfIGGyQxMTMeZG9lGkBOA0KQfkvIFz8L5DYy2I2iNyHlXLKJTm0mww024ED+NqXXQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Z1OEcZZhRQOA/CSPFPuN8awYR62qRa4pgZw4qA38O6/4UFY/qUh37pygGW6u+cILbh8YqI2q3OsrVRGCe9MIWM8tScQnAvk375wfCLXlXrB+bnnFKX17GnnPchv4hJJDQV/oD8/xM31zJRP/eMyWQLfgxV1A6aGSrIwWJesW/s7GgV96dyC22VSTnZk59b/ZQ2Vf3migCztVI8Au1LmnrUZkvwsL20dcEzhMM2mHIIw/taW51s8EsYQ4cZ8g02tglSoRaNeCrdKW54ZipNHUZV78Ld5r9wyJvsnvnkA59/3KxTqlfEFF4sOQb2wE1d/Bdi505IrGLvM2oQyMh1Epgw==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Gianluca Guida <gianluca@xxxxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Thu, 23 Feb 2023 13:34:57 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 20.02.2023 17:40, Oleksii Kurochko wrote:
> --- a/xen/include/xen/lib.h
> +++ b/xen/include/xen/lib.h
> @@ -24,12 +24,12 @@
>
> #ifndef __ASSEMBLY__
>
> +#include <xen/bug.h>
> #include <xen/inttypes.h>
> #include <xen/stdarg.h>
> #include <xen/types.h>
> #include <xen/xmalloc.h>
> #include <xen/string.h>
> -#include <asm/bug.h>
>
> #define BUG_ON(p) do { if (unlikely(p)) BUG(); } while (0)
> #define WARN_ON(p) ({ \
As just said in reply to patch 1 - I can't see how this would build
at this point. There looks to be an ordering problem; you first need
to remove from asm/bug.h what's now also available from xen/bug.h.
Possibly parts of patches 3 and 4 need to move here.
Jan
|
