[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] xen/compiler: Clang 14 and later understands attribute((error))
- To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Thu, 23 Feb 2023 13:36:29 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=uLgsLmQtTZN2kToEkHZVHqlcygnCFH/JW/Ths5GoQqU=; b=gvb1GDtyLiWeiAlwBQqadY7mTzYCoSGj9TG0udy4IN30GqsaT/doxkTQBaLFu92A+58FHYm0hWrUzvWSc6tT6k/RQoleHh5167Idm3lSnSa8I9odu5BLrYBcVE6qz6D6K79kW9alzZJFsi71usLhc5A4OisyiiDfNoHRLVH+54RP/QdsiFIK/lmda61E+Pe8GSBWL5XyZl9d+zoZVo7INlpgM57C/588gc5NVf/V0w1xPZ7EetkLGFbufdx7GHIlSJdNcBwdR5JaIaeJTR1CZwFtbY5W59yWCIIvLzEXkC5xK/5eb3yk0MBJsKZ0qNbZCs7ZFWnNO2U+PDrXgIzPHg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=c3hRyj/t39fS+VC8X2UxofthLFmyfj3+7a6meEx5O2UAc4k5nJ0qBCnVDQoshm+nbT2KPbxp8mRZnUKWBCoh/6xGn3194wMf5CjqI5tJRM1o6/BN9ZoNwNhdz8N7gMpAfIBlTjjcNvXBSj/yGG8j8ccxjiaidFwhhSG1YoZZ0w9uBn5Z8S5xFTb28PCgZxQHPFUnGgMwd1xNJFnk2t+ZRZuMO1am8GEr7hZpwQgozToD+ah7S7Hd1bum990+FnKEX+AQx8mt8YgN2OcAbZolCtXQt6R4T3UMXqMKYrA0QJ4BoyayGEJH0E3MwrqBLj/AHBocNB9lUg//WkYVaLpYOw==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Thu, 23 Feb 2023 12:36:42 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 23.02.2023 13:22, Andrew Cooper wrote:
> --- a/xen/include/xen/compiler.h
> +++ b/xen/include/xen/compiler.h
> @@ -31,7 +31,7 @@
>
> #define __weak __attribute__((__weak__))
>
> -#if !defined(__clang__)
> +#if !CONFIG_CC_IS_CLANG || CONFIG_CLANG_VERSION >= 140000
Hmm, for the sake of getting the functional change in,
Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
but this clearly is against the Kconfig usage proposal: Following that,
such conditionals should not reference CONFIG_*, as the .config may
have been generated not only with a different Clang version, but also
with gcc instead of Clang. While there were a couple of comments, no
counter proposal appeared so far, there was one explicit agreement
with the proposal, and the requested patch demonstrating the
intentions wasn't commented on either. One might conclude that as per
our lazy consensus approach the proposal holds, and no such new uses
violating its principles should be introduced. The more that the same
can easily be expressed differently.
Jan
|
