[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 9/9] x86/vmx: move vmx_update_debug_state() in vmcs.c and declare it static


  • To: Xenia Ragiadakou <burzalodowa@xxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Thu, 23 Feb 2023 12:21:23 +0100
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xw9D5mdgKcnpvAMfjDO2OzSEn6KCENZiGCFyuuq0Vhc=; b=BT06Bxj/DW/FeOxLRW3+VLfpx5P7TsDjotQDLZlAXbPDDmKZsOvXoBP72u9Cvv9M/nU/Xo/yIiHyIB+XViIIAD5knLiNZmOTwYXjFSWzTnwtDuwSddrjIuwfdvB/kcUsAkYIfSDkcEKpWMZpsCytLDcZjQYUI+5VGjQwIlemEyPbfvctZETuZM4ddqSngqVoy+y8HD/GZpXhvaxVTceQKtyrbYSGSC24SpvKq4YSUhL3+4cVu6I8kwOkWn+x0pSgs6HTEvZC4ruJdxmyRFelIozk19TO9iAGHWCOluUkZupayc7hj1XP5FM8U5XR1haAuBrrCsaZTlI71hApyp4X0w==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PZExSY8i2mon/u5VnKg25lUSsa2GOOwwqW6ZPhIFvbJN6ushWnwg663sDV1UkacGfZvbgnVym70TKpcTW9D2NZzEJUW+qH7KIEiB1kI4yaBNMnzna1HXRfabejddz+5lYPa64m3n2MAoXhR9flux7Z8bES9D+p1etQsx9JKNK9VLTqd+ASOqLNIWelthfBvgu5K1x+J6YMPfSIRyYfMC852PRtVe3uLpsxqHOQbs0o5fVUQPortsL/uvYSAADP1AbngPRgdfER+H5TTx86JRWj6VEDnhmKfnh2TpePCoGxn/NzpYHuIYFGZCm0RlK3j5LlR2oAP3SM2i15+PwCalcg==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
  • Cc: Jun Nakajima <jun.nakajima@xxxxxxxxx>, Kevin Tian <kevin.tian@xxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
  • Delivery-date: Thu, 23 Feb 2023 11:21:34 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 22.02.2023 13:00, Xenia Ragiadakou wrote:
> Move vmx_update_debug_state() in vmcs.c because it is used only in this
> file and limit its scope to this file by declaring it static and removing
> its declaration from private vmx.h
> 
> Signed-off-by: Xenia Ragiadakou <burzalodowa@xxxxxxxxx>

Perhaps move this ahead in the series, so you don't need to touch ...

> --- a/xen/arch/x86/hvm/vmx/vmx.h
> +++ b/xen/arch/x86/hvm/vmx/vmx.h
> @@ -14,7 +14,6 @@ void vmx_intr_assist(void);
>  void noreturn cf_check vmx_do_resume(void);
>  void cf_check vmx_vlapic_msr_changed(struct vcpu *v);
>  void vmx_realmode(struct cpu_user_regs *regs);
> -void vmx_update_debug_state(struct vcpu *v);
>  void vmx_update_exception_bitmap(struct vcpu *v);
>  void vmx_update_cpu_exec_control(struct vcpu *v);
>  void vmx_update_secondary_exec_control(struct vcpu *v);
... this header again right away?

Jan



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.