[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 3/4] x86/vmx: cleanup vmx.c
- To: Xenia Ragiadakou <burzalodowa@xxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Tue, 21 Feb 2023 12:26:57 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0F67tXSTHNqaUTkh/QGVMf9NcUn1Xf9/Wcd+ZhxdqeA=; b=Gdm/lYWh4QmEhxYxQGBxDOZofKkH2XcaEa+xNNhNNDa1MmPCLwkNAvOl1uNPVWYZcVoajSE5YkgtIcLv4LxpOT08+XduF3ZKjC2b35K9heyX3bsGRQapoSnVbI9niF/a0IOzlmQVnO8wBGpfNYujtieco7aJG/6tdgCUsJmqUDR5pBu9HneZ7f4Kyg+LD6gSrXEXHBkc5Klg5kFKuTfh5YEjLWdkNBQC6/RBp7BHZSHDVsStRIJp3i0euloLTw6YEBqeRZ1CI8AVOHfTflWQCI1LbqU24z4l0U5fDbBhCu6pjoO+GMUx26SLgYiZ+6yWQMClSWWAGqH5k8ln0zqyqw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZNqERMhBMgyPFQyWrMcMQ9yUq809ZciMukTmFWafXtB4lecb0Pq/Yxp07kudmGIJmro/ud30qx/1eClrdACIFrE2X8MrnjFTrlVM/fQathebFD1q9IlFZr/yvVsotJ8IuGlRLIkzRnjh+at7oF9y2xHITqnFCy80ul+7E35OvkTJCVW1m20mi5hfCUMTA92D91UTJCtBsg9rcHrjs1GRjR2sJJwIVkkoqQU7W9JFED8WD6TPL/xRiNjoHf2SW+IzPbojl4X5hYLVzUF1k41FZQj/OvakHZgfb7f8+uFW0/oY55XoiL8PMMAhGC/kOi+SvEZbnuPEZbEjBu9bIKNlvg==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Jun Nakajima <jun.nakajima@xxxxxxxxx>, Kevin Tian <kevin.tian@xxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Tue, 21 Feb 2023 11:27:09 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 17.02.2023 19:48, Xenia Ragiadakou wrote:
> Do not include the headers:
> asm/hvm/vpic.h
> asm/hvm/vpt.h
> asm/io.h
> asm/mce.h
> asm/mem_sharing.h
> asm/regs.h
> public/arch-x86/cpuid.h
> public/hvm/save.h
> because none of the declarations and macro definitions in them is used.
> Sort alphabetically the rest of the headers.
>
> Rearrange the code to replace all forward declarations with the function
> definitions.
>
> Replace double new lines with one.
>
> Reduce scope of nvmx_enqueue_n2_exceptions() to static because it is used
> only in this file.
>
> Move vmx_update_debug_state() in vmcs.c because it is used only in this file
> and limit its scope to this file by declaring it static and removing its
> declaration from vmx.h.
>
> Take the opportunity to remove all trailing spaces in vmx.c.
>
> No functional change intended.
>
> Signed-off-by: Xenia Ragiadakou <burzalodowa@xxxxxxxxx>
> ---
> xen/arch/x86/hvm/vmx/vmcs.c | 12 +
> xen/arch/x86/hvm/vmx/vmx.c | 5844 ++++++++++++------------
> xen/arch/x86/include/asm/hvm/vmx/vmx.h | 1 -
> 3 files changed, 2913 insertions(+), 2944 deletions(-)
I'm afraid this is close to unreviewable and hence absolutely needs splitting.
With this massive amount of re-arrangement (it's half of vmx.c, after all) I'm
also concerned of losing "git blame"-ability for fair parts of the code there.
Jan
|
