[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] x86/asm: ELF metadata for simple cases


  • To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Tue, 21 Feb 2023 12:05:40 +0100
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=K7b2sPbg74o7vk11pYUg/xe/lpQ5BS3jZ0zJm4V/RDk=; b=NJKiwjpSkpGi+0Q/b+itapEuJNMJVuWVsDB/j6P2drK62PN+NryIjrEQhu52zau79fVg0uCV2xLmJWtxWZtyh2gY9KA9/+YNWyiuHD7I9Koe0+a+k7aR0vaSGsJ9TWW8Ufm9UPw4WdB+f5emTO44cu85/mZ8vnLDmkaCIGwtnMOjU8IJure+Y84ZJXkJZMTVbE2bNhC9j7MI9tw3wGCzu57Mc1o/LiM03DaTxbUW1i/VlYgUidq8/qZX8YbmVwNxNmTmjM85rmvd6CcFeaQER/c42iodu8A9SxSgnxwy+1R88Xsr7qR8bdCaJBtHO18WcbvslzBZRJAQOExJyVJM4w==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=b7TE+5Jy8SNY67yCQa85On4I4/XZxL08EJd4Do6XkM1UfuFttG9yr0iLEPwOEv3B8OPT1upwlm9JT5VBDbHnHzHVDo3cg+HJq4G42w61hs6d0ZVLgOjR7YnY7XP3aeaStDDSoPim8EYfegBBg0CziSJCwzCmkEFVezJ52zhaXMrCQpUBxHVT/s6WT1/platg/yoNro82JAdO6+kaoia7fmzb/bjie7UGVI97yN8XEPJJ1i6Ic5BFXjh6hKA0OmYchdY1a7qWEESVfpKks9PuY42OmawqrPq6XRcgUSjCRtLdDFknly66F2luLAPPIO2e6BR4sWXKaogRqJ9YwIzZ6g==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
  • Cc: Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>, Ross Lagerwall <ross.lagerwall@xxxxxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • Delivery-date: Tue, 21 Feb 2023 11:06:32 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 20.02.2023 12:04, Andrew Cooper wrote:
> This is generally good practice, and necessary for livepatch binary diffing to
> work.
> 
> With this, livepatching of the SVM entry path works.  The only complication is
> with svm_stgi_label which is only used by oprofile to guestimate (not
> completely correctly) when an NMI hit guest context.
> 
> Livepatching of VMX is still an open question, because the logic doesn't form
> anything remotely resembling functions.  Both code fragments jump into each
> other so need to be updated in tandem.  Also, both code fragment entries need
> trampolines in the case that patching actually occurs.  For now, just treat it
> as a single function.

I agree.

> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

Acked-by: Jan Beulich <jbeulich@xxxxxxxx>





 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.