[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/4] x86/svm: cleanup svm.c
- To: Xenia Ragiadakou <burzalodowa@xxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Date: Mon, 20 Feb 2023 22:12:00 +0000
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8CZ9xh4uPgpeeBH6akqmJ0HUOpbOWuDJAv/CjYdHLhU=; b=L1dSQQqLo/P71lc35dsosRrElOLhornx7SD66d2PGpT2o8sg9EGHrAUBGnBzDkgN/aRcY9YISjHgMQM1S4ZeFIbH6e5TVSlz1dDoJRp9c2PF5qYGeNfBgmUXONmJ8WEqsiGPm5mwpxe9PUocflz4cMEtVv//tCYWbX1iXYJtY5bfDfGf/YIXOGpsFcijiBKE2mQy+59Ydz6XznWVu6WohZgc8MKwwi/Xzf7cQzZxZlx5SK7KZsTT29hNCu6mx3TgOfVW5kxLh2TDOLgtx+moJ1nTJu495kBWrPXWzrq2ke/XHqriQesELRQQ9UuFoG7kkaKFQispUsV5f7dn5JjE1A==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eeTbhuJo0ZwfJFjTlNSXz5XcL+diBkaUS0eSC3HUCVydJlVNbp5iTa2Q/BiBJOwsLGTkcl3byYH7KIffsIM+jh7cMffeGrW3g3vvwi4prcx+QvihC2JRUZwjFwrMabcLh6QyLGySDJtGL5htTDUtCg3GGLr1l6L25Q5Vno0SAUO3knCtBDuUNJfkaUH6hntWY93BBgjLKXtLE3U4V5dK40YYeEAD5wZH+Vo3lw0xYMdOksECMbHaQrptNATe4R54WUZzX4CMl+mCIzuZ+Wlx0eIO4hr8fwAXtJNumCHqwQOU/A5UUnxehpCAgcPfTWCwYyYlLFxNh1LYvgvfmbF9fg==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Jan Beulich <jbeulich@xxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
- Delivery-date: Mon, 20 Feb 2023 22:12:33 +0000
- Ironport-data: A9a23:3pTfq60J9Plgl4VLHfbD5elwkn2cJEfYwER7XKvMYLTBsI5bpzVRy mROWW7TOazeYzfzfdF0adu29EICucPSzIRgHFBvpC1hF35El5HIVI+TRqvS04F+DeWYFR46s J9OAjXkBJppJpMJjk71atANlVEliefTAOK6ULWeUsxIbVcMYD87jh5+kPIOjIdtgNyoayuAo tq3qMDEULOf82cc3lk8tuTS93uDgNyo4GlD5gZkPagR1LPjvyJ94Kw3dPnZw0TQGuG4LsbiL 87fwbew+H/u/htFIrtJRZ6iLyXm6paLVeS/oiI+t5qK23CulQRrukoPD9IOaF8/ttm8t4sZJ OOhF3CHYVxB0qXkwIzxWvTDes10FfUuFLTveRBTvSEPpqFvnrSFL/hGVSkL0YMkFulfB1xnr dc7Ciw0Tk6Hp72U/o2LdeVHr5F2RCXrFNt3VnBI6xj8VK5ja7acBqLA6JlfwSs6gd1IEbDGf c0FZDFzbRPGJRpSJlMQD5F4l+Ct7pX9W2QA9BTJ+uxouy6KlFYZPLvFabI5fvSjQ8lPk1nej WXB52njWTkRNcCFyCrD+XWp7gPKtXqjANhITuPmqZaGhnWM+V4YGA87WWGxpMCI2kiAAvB0F xwLr39GQa8asRbDosPGdxelumyNuhkQXMVZO+I/4QCJjKHT5m6xFmUCCzJMdtEinMs3XiAxk E+EmcvzAj5iu6HTTmiSnp+Wpz6vPSkeLUcZeDQJCwAC5rHLv4Ubnh/JCNF5H8aIYsbdHDjxx 3WAqnc4jrBK1coTjfzjpxbAni6moYXPQkgt/ALLU2m57wR/Iom4e4iv7lud5vFFRGqEcmS8U LE/s5D2xIgz4VulzkRhnM1l8GmV2su4
- Ironport-hdrordr: A9a23:9WzPLKE2WzsC9iXDpLqE+ceALOsnbusQ8zAXPiFKJCC9F/by/f xG885rtiMc9wxhOk3I9ervBEDiex/hHPxOgbX5VI3KNDUO01HGEGgN1+rfKjTbakjDytI=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 17/02/2023 6:48 pm, Xenia Ragiadakou wrote:
> Do not include the headers:
> xen/irq.h
> asm/hvm/svm/intr.h
> asm/io.h
> asm/mem_sharing.h
> asm/regs.h
Out of interest, how are you calculating these? They're accurate as far
as I can tell.
Looking at asm/hvm/svm/*, intr.h itself can be straight deleted,
svmdebug.h can be merged into vmcb.h, and all the others can move into
xen/arch/x86/hvm/svm/ as local headers. None of them have any business
being included elsewhere in Xen.
> because none of the declarations and macro definitions in them is used.
> Sort alphabetically the rest of the headers.
Minor grammar point. "Sort the rest of the headers alphabetically" would
be a more normal way of phrasing this.
>
> Remove the forward declaration of svm_function_table and place start_svm()
> after the svm_function_table's definition.
>
> Replace double new lines with one.
>
> No functional change intended.
>
> Signed-off-by: Xenia Ragiadakou <burzalodowa@xxxxxxxxx>
Acked-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
|
