Re: [PATCH v2 1/3] automation: move yocto jobs to build stage

[Michal Orzel <michal.orzel@xxxxxxx>]

Hi Stefano,

On 15/02/2023 23:09, Stefano Stabellini wrote:
> 
> 
> From: Stefano Stabellini <stefano.stabellini@xxxxxxx>
> 
> We are going to use artifacts produced by the Yocto builds in test jobs.
> 
> Signed-off-by: Stefano Stabellini <stefano.stabellini@xxxxxxx>
> ---
>  automation/gitlab-ci/build.yaml | 51 +++++++++++++++++++++++++++++++++
>  automation/gitlab-ci/test.yaml  | 45 -----------------------------
>  2 files changed, 51 insertions(+), 45 deletions(-)
> 
> diff --git a/automation/gitlab-ci/build.yaml b/automation/gitlab-ci/build.yaml
> index a053c5c732..f62cf21f45 100644
> --- a/automation/gitlab-ci/build.yaml
> +++ b/automation/gitlab-ci/build.yaml
> @@ -199,6 +199,41 @@
>    variables:
>      <<: *gcc
> 
> +.yocto-test:
> +  stage: build
> +  image: registry.gitlab.com/xen-project/xen/${CONTAINER}
> +  except:
> +    - master
> +    - smoke
> +    - /^coverity-tested\/.*/
> +    - /^stable-.*/
stage, image and except are the same as in &build template.
You could just use <<: *build to reuse them. Specifying script here would 
overwrite the build script
and we do not care about artifacts paths (i.e. if it is not produced by a job, 
there will be just a warning
which is already the case for some jobs). Anyway, this is just a suggestion to 
save some lines, so with or without:

Reviewed-by: Michal Orzel <michal.orzel@xxxxxxx>

~Michal