[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] x86/Xen: drop leftover VM-assist uses
- To: Jan Beulich <jbeulich@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Date: Thu, 16 Feb 2023 13:46:28 +0000
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4/CYXEnbNwvj9nzCZ5CA4+V4KudfCULd9RHunL4tA9U=; b=AUIdx6O5N/zba4AQ44X953LoSEJLW52URzosBnWeP9Wy/qIoz3LIhbonou1XMjt4ey4JRHakNdhuNcl/C0Q+G/2sIoZdH2qUPVByjgsr9SAMKSf4kkNWxeDqbDqomJJqbKpvdoHPuyT2LvP6s3OodOHI1twuVo4UVtLa3jmHYPfjei+Q/2DEYWFd76RfbtefgbqNSGSmO8tbtSiIC8QFx77NaopObF29huG3VOhrZmJGcDGRUQYtCJbCN5bFcpJbMgY6LncF2VTCv+F/TlT7vgmYwNBnDcemJMCN4WNxZ87FRYNu3oMDE6AVzfwvB/TRCDqNvD9Vk6sPrNQBgDjpdw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gWe2jEb/I/kRLUd146hXLaHdPbDpkA6J3IzYqozgFEQ7WM6E/E5wpB/WZm4XAOhdAZ/0d4USfI/DhfQ+XktpDUnyW3h6Shyfqy0knKeMg3H7K04s1pcJcik5atZBc2u/tUNfKHqSaH82svuc02155hmbms1GYW1qzDf2q5XjLXCQ1rMPUGSqcBw/syKKd4/IWRrfAsV7L1haQnppfgU3thsP587i85H5Z5Z2Y8MFJlu2CnWJNfe78M8/CCXpXkFb98b+H3ehA7w10PxcGtftfw5LAPVp4An8qE55D6aGU485LizGo0Re1aHlcHgE8QPoqry5kq2ObZDU+VLskTucPg==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Juergen Gross <jgross@xxxxxxxx>, Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>
- Delivery-date: Thu, 16 Feb 2023 13:46:56 +0000
- Ironport-data: A9a23:yl3X2qLTNW/AZT0kFE+RHJQlxSXFcZb7ZxGr2PjKsXjdYENS0z0Hx zYWXTyEafiMNDHzco1yPNiyph4O78TcnINgSFFlqX01Q3x08seUXt7xwmUcnc+xBpaaEB84t ZV2hv3odp1coqr0/0/1WlTZhSAgk/rOHvykU7Ss1hlZHWdMUD0mhQ9oh9k3i4tphcnRKw6Ws Jb5rta31GWNglaYCUpJrfPcwP9TlK6q4mhA5AVgPakjUGL2zBH5MrpOfcldEFOgKmVkNrbSb /rOyri/4lTY838FYj9yuu+mGqGiaue60Tmm0hK6aYD76vRxjnVaPpIAHOgdcS9qZwChxLid/ jnvWauYEm/FNoWU8AgUvoIx/ytWZcWq85efSZSzXFD6I+QrvBIAzt03ZHzaM7H09c59W35c9 aU/BgsVQTXbjuOY++2/dOBz05FLwMnDZOvzu1lG5BSAVbMDfsqGRK/Ho9hFwD03m8ZCW+7EY NYUYiZuaxKGZABTPlAQC9Q1m+LAanvXKmUE7g7K4/dqpTGLkWSd05C0WDbRUvWMSd9YgQCzo WXe8n6iKhobKMae2XyO9XfEaurnzHyhAthIT+PQGvhCsnmt53EjVUQtCkb4mt3jjE/5QNkPJ BlBksYphe1onKCxdfH/VRClpH+PvjYHRsFdVeY97Wml2qfSpgqUGGUAZjpAc8A98t87QyQw0 V2ElM+vAiZg2JWXRmia7ay8ti6pNG4eKmpqTSUDVwoepd74vJs0kAnMX/5kCqe+itCzEjb1q w1mtwA7jrQXyMsUjaOy+Amfhyr2/8CUCAko+g/QQ2SpqBtjY5KobJCp7l6d6utcKIGeTR+Ku 31sd9Wi0d3ixKqlzESlKNjh1pnwjxpZGFUwWWJSIqQ=
- Ironport-hdrordr: A9a23:pG9btqlelCmsVzNO+ePPdI015xXpDfI93DAbv31ZSRFFG/Fw9v rCoB1/73SftN9/YgBCpTn+AtjjfZqxz/BICOoqUYtKPjOHhILAFugL0WKI+VLd8kPFl9K13J 0QFpRDNA==
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 15/02/2023 11:27 am, Jan Beulich wrote:
> Both the 4Gb-segments and the PAE-extended-CR3 one are applicable to
> 32-bit guests only. The PAE-extended-CR3 use, furthermore, was redundant
> with the PAE_MODE ELF note anyway.
>
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
>
> --- a/arch/x86/xen/setup.c
> +++ b/arch/x86/xen/setup.c
> @@ -934,12 +934,8 @@ void xen_enable_syscall(void)
>
> static void __init xen_pvmmu_arch_setup(void)
> {
> - HYPERVISOR_vm_assist(VMASST_CMD_enable, VMASST_TYPE_4gb_segments);
> HYPERVISOR_vm_assist(VMASST_CMD_enable,
> VMASST_TYPE_writable_pagetables);
I find it disappointing that a PV guest which states a hard dependency
on writeable pagetables in its elfnotes doesn't have this activated
automatically.
The PV API/ABI truly is an undesigned mess.
~Andrew
|
