[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3] x86/vlapic: call vmx_vlapic_msr_changed through an hvm_function callback
- To: Xenia Ragiadakou <burzalodowa@xxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Date: Thu, 16 Feb 2023 10:28:13 +0000
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Fv4TB/grq4QMcivVPhYF6xvG2OLyJXSh7ZjYzZ4hUho=; b=MuPtFTKzlfzkgyjZEgjMCquKE771l8jaz+R3yOUbRnkoWfyj/R8KXuTnoms5EOLI0KXzsagJ7uOvg+cWH+KgBAIqQmfoScnlfGK7TQ6gyfURSSU5/e8U+5EqfbY9BXgzi2OwaflAgIRXcWnRGm97F53uAimcVxKzBVkOFW7vAE5PRl7rIZ5EIwZn+iOZwFEleL2Z9EOmO16m0771ZIQDtjlMYema6Lqk0oxFbqYf5Cdu8+qezFf88n8b1GAWX/5W03Gf+jQjH1QP8pI/gIlrtLCPv93eSPLCxBVxtJ0pu9XCmr5eVMBequ8V00JaVUJiq9DNwokePE8AbFCx0e8fzA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KvUp4B39VChGe5voUsUIcASDxZIewLFHm9s99rz2bhl0XgqFta42D6D42lMAw1TQGOuilvVWTGWNWnnB5fQ3ofl+RgLPieanYkE5Ncm0KP31iaVVcVR4fywaN1Bg89xa8A3ytLkpcrhUuipjwCge49DIn/HSSOT2AlFn4FdoaCWkL/vHRo5hdSxd86ThvmnqmoDLemeKq6yF/apEGnzQrwJUiUZxqpUKRD437Q9S+9expffJQyQDHQT4J4ac8mVBdzP5qfgjTlAItt+O4i6hJbms4kuoYh++XjHl5gzFpxR4bfpfVrqSUN6y5X/QRaxavtw0FEpog+/RDkjOrAW9cQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Jan Beulich <jbeulich@xxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Jun Nakajima <jun.nakajima@xxxxxxxxx>, Kevin Tian <kevin.tian@xxxxxxxxx>
- Delivery-date: Thu, 16 Feb 2023 10:28:48 +0000
- Ironport-data: A9a23:x7zsU6DFBrnbRhVW/8Hiw5YqxClBgxIJ4kV8jS/XYbTApDtwhTUHm zBLD23QbK7eZ2TwLtojat/i9EgPvMDXmNBrQQY4rX1jcSlH+JHPbTi7wuUcHAvJd5GeExg3h yk6QoOdRCzhZiaE/n9BCpC48T8nk/nOHuGmYAL9EngZbRd+Tys8gg5Ulec8g4p56fC0GArIs t7pyyHlEAbNNwVcbyRFtMpvlDs15K6p4GlB4ARnDRx2lAS2e0c9Xcp3yZ6ZdxMUcqEMdsamS uDKyq2O/2+x13/B3fv8z94X2mVTKlLjFVDmZkh+AsBOsTAbzsAG6Y4pNeJ0VKtio27hc+ada jl6ncfYpQ8BZsUgkQmGOvVSO3kW0aZuoNcrLZUj2CA6IoKvn3bEmp1T4E8K0YIw28lFAn8V9 NUkNnMxNjaDm+Dm76zhc7w57igjBJGD0II3nFhFlGicJtF/BJfJTuPN+MNS2yo2ioZWB/HCa sEFaD1pKhPdfxlIPVRRA5U79AuqriCnL3sE9xTI++xuvDe7IA9ZidABNPL8fNCQSNoTtUGfv m/cpEzyAw0ANczZwj2Amp6prr6QxHKqCN5OfFG+3s5Usgyu+U8vMUMPflu0ocO5l0ygYd0Kf iT4/QJr98De7neDRMTnTRS8p3KDoRc0VN9ZEul84waIooLE7gDcCmUaQzppbN09qNRwVTEsz kWOnd7iGXpoqrL9YXCX+6qQrDiyETMINmJEbigBJSMa5/HzrYd1iQjAJv5hDajziNT2EDPxx jmirS4iirFVhskOv4248E7GhXSwp5HPZg8z+gjTGGmi62tEiJWNYoWp7R3Q6q9GJYPAF12Z5 iFbxI6Z8fwECoyLmGqVWuIREbq15vGDdjrBnVpoGJpn/DOok5K+Qb1tDPhFDB8BGq45lfXBP RW7Vd95jHOLAEaXUA==
- Ironport-hdrordr: A9a23:Or4UYa5OfNgrlqM2vQPXwMzXdLJyesId70hD6qkXc20zTiX4rb HLoB1/73TJYVkqNE3I9eruBEDjex3hHO9OgbX5VI3KNGOKhILCFuBfBOXZsl/dMhy72ulB1b pxN4hSYeeAaGSSVPyKgzWFLw==
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 13/02/2023 11:50 am, Xenia Ragiadakou wrote:
> diff --git a/xen/arch/x86/include/asm/hvm/vmx/vmx.h
> b/xen/arch/x86/include/asm/hvm/vmx/vmx.h
> index 234da4a7f4..97d6b810ec 100644
> --- a/xen/arch/x86/include/asm/hvm/vmx/vmx.h
> +++ b/xen/arch/x86/include/asm/hvm/vmx/vmx.h
> @@ -85,7 +85,7 @@ typedef enum {
> void vmx_asm_vmexit_handler(struct cpu_user_regs);
> void vmx_intr_assist(void);
> void noreturn cf_check vmx_do_resume(void);
> -void vmx_vlapic_msr_changed(struct vcpu *v);
> +void cf_check vmx_vlapic_msr_changed(struct vcpu *v);
Hi,
I see this patch has been committed, but this public declaration should
deleted, and vmx_vlapic_msr_changed() made static now that it's only
referenced in vmx.c.
It needs a forward declaration in vmx.c because of its position relative
to the vmx_function_table, but that's fine - we've got plenty of other
examples like this.
Could I talk you into doing an incremental fix?
Alternatively, we could get better cleanup by forward declaring just
{vmx,svm}_function_table, then moving the tables to the very bottom of
{vmx,svm}.c at which point we can drop all the forward declarations.
Oh top of that, I suspect we have other public function definitions
which can turn static, if you happen to spot any while doing this.
Thanks,
~Andrew
|
