[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 3/5] automation: Add a static memory allocation test on arm32


  • To: Michal Orzel <michal.orzel@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
  • From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
  • Date: Thu, 16 Feb 2023 01:19:08 +0000
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Js1GesCnGjYso5HBqdg8LKv+7LiWNm3CiZn2vEHvEVc=; b=mbNG26RF024hgPhdmsEh7y5FH/SapXOpTUoh8bcsA097WBiJjTtfoTFW150D39cbmtWUgRA8fpMkKq9Ukq0w9bmjJov7gs8itY7yYnnJdBucJOTs+A9swZk0k9GhsF0kv3R5f1XDjvFhyKhaeBGbDDF0JtVdUYBNGQlrSHYjT0xSsfyfg8uexeSvaOF+hupRA/mjt8ZB+oUTtJsHtu04QeY8kFsk4+lq+CXS9OK2eSwVpT3TcTCD+bjNng8kC54R7uC0aDwNzzm/WFI+nI/hQQA6mimBjqtjoDQloFCdDja0vruNndAWxp8OD3S6zQWkeM2kLLoRQ2swW08EiwSx4A==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Q/8zBYgf20zx7wK2ZYfeJ8agf8Ce0hV9oEpbg0/XrevFTW1TW2UfKhpcvbIHeRxTW46GMwN7x9uWg0Intn6ZVljvN2fHt1tYrSpNSE+Mi4Ihfe1gt4Us3SMq82obLvfuTFfUYy9CGfqsM54E5JRDlCjmfK81B5IdCM2QhfBsOBnjs1zisUv5Sjq1eJ4COxoYYzEmu8942QjQm2gsHABr+kTs8nUrU2wOFKmZ5vUnjf5WHkAyeH8DEMfctMqAGBfKAzOASXTr0hgWRgcB4Ewk/NM99IDAdmPLbJKnvIledOpm5NcE1LOWEbE0Geg5QdEZ6J+oLj0ShZYeGL2OPye6Xw==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
  • Cc: Doug Goldstein <cardoe@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>
  • Delivery-date: Thu, 16 Feb 2023 01:19:36 +0000
  • Ironport-data: A9a23:S6I6UKrj1QQMncTasoqrQjTMC2NeBmLUZBIvgKrLsJaIsI4StFCzt garIBmPPq3Ya2L8Ldx/aIrk901U7MPdx4U2GQM6pXswFykbpJuZCYyVIHmrMnLJJKUvbq7FA +Y2MYCccZ9uHhcwgj/3b9ANeFEljfngqoLUUbKCYWYpA1c/Ek/NsDo788YhmIlknNOlNA2Ev NL2sqX3NUSsnjV5KQr40YrawP9UlKm06WxwUmAWP6gR5weEziRNV/rzGInqR5fGatgMdgKFb 76rIIGRpgvx4xorA9W5pbf3GmVirmn6ZFXmZtJ+AsBOszAazsAA+v9T2Mk0MC+7vw6hjdFpo OihgLTrIesf0g8gr8xGO/VQO3kW0aSrY9YrK1Dn2SCY5xWun3cBX5yCpaz5VGEV0r8fPI1Ay RAXAG40ahCDvsS5/L7lYbU0qtY6IorSYrpK7xmMzRmBZRonabbqZvyQoPN9gnI3jM0IGuvCb c0EbzYpdA7HfxBEJlYQDtQ5gfusgX78NTZfrTp5p4JuuzSVkFM3jemraYWOEjCJbZw9ckKwj 2TK5WnmRDodM8SS02Gt+XOwnO7f2yj8Xer+EZXpqac20ADKmAT/DjUyDHm3jKm9yXe4Ad1iD 0so9hYOhKoboRnDot7VGkfQTGS/lhsdUNpZF6s98hOAzoLd5grfDW8BJhZRZdpjuMIoSDgC0 l6Sg8ivFTFpqKeSS3+W6vGTtzzaESMcN2MFaAcPRBEJ5NSlq4Y25jrUVcpqGqOxitzzGBnzz iqMoSx4gK8c5fPnzI2+9FHDxj6p+J7AS1dv4h2NBz3+qARkeISieoqkr0DB6upNJ5qYSV/Hu 2UYn8+Z76YFCpTleDGxfdjh1YqBv56tWAAwS3Y2d3X931xBI0KeQL0=
  • Ironport-hdrordr: A9a23:hngX2q+aUd+br/Tz4z5uk+AuI+orL9Y04lQ7vn2ZKSY5TiVXra CTdZUgpHnJYVMqMk3I9uruBEDtex3hHNtOkOss1NSZLW7bUQmTXeJfBOLZqlWNJ8S9zJ856U 4JScND4bbLfDxHZKjBgTVRE7wbsaa6GKLDv5ah85+6JzsaGp2J7G1Ce3am+lUdfng+OXKgfq Dsm/auoVCbCAwqR/X+PFYpdc7ZqebGkZr3CCR2eyLOuGG1/EiVAKeRKWnj4isj
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 14/02/2023 3:38 pm, Michal Orzel wrote:
> diff --git a/automation/gitlab-ci/build.yaml b/automation/gitlab-ci/build.yaml
> index f8e156e0a994..079e9b73f659 100644
> --- a/automation/gitlab-ci/build.yaml
> +++ b/automation/gitlab-ci/build.yaml
> @@ -565,6 +565,26 @@ debian-unstable-gcc-arm32-debug-randconfig:
>      HYPERVISOR_ONLY: y
>      RANDCONFIG: y
>  
> +debian-unstable-gcc-arm32-staticmem:
> +  extends: .gcc-arm32-cross-build
> +  variables:
> +    CONTAINER: debian:unstable-arm64v8-arm32-gcc
> +    HYPERVISOR_ONLY: y
> +    EXTRA_XEN_CONFIG: |
> +      CONFIG_EXPERT=y
> +      CONFIG_UNSUPPORTED=y
> +      CONFIG_STATIC_MEMORY=y

This is absurd.  Either

1) static mem is important enough to warrant testing.  By adding it to
CI, you have caused the maintainers to accept the responsibility of
fixing bugs found in it, making it by definition supported, or

2) it is not important enough to warrant testing, at which point it's
not ok to be using XenProject's limited testing resource like this, and
it's not ok to be a blocking test.

There is no such thing as an unsupported feature running in CI.  It is a
complete contradiction in terms.

~Andrew



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.